[Filters] Add an internal feature key for enabling GraphicsContext filters #6906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shallawa
added
the
Layout and Rendering
|
EWS run on current version of this PR (hash e4407b3) |
…lters https://bugs.webkit.org/show_bug.cgi?id=248375 rdar://102689264 Reviewed by Sam Weinig. This key will be used for enabling GraphicsContext filters giving that all the FilterEffects in the filter chain support CoreGraphics filters. * Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/page/Page.cpp: (WebCore::Page::preferredFilterRenderingModes const): * Source/WebCore/platform/graphics/GraphicsContext.h: (WebCore::GraphicsContext::style const): (WebCore::GraphicsContext::setStyle): * Source/WebCore/platform/graphics/GraphicsContextState.cpp: (WebCore::GraphicsContextState::mergeLastChanges): * Source/WebCore/platform/graphics/filters/FilterImageTargetSwitcher.cpp: (WebCore::FilterImageTargetSwitcher::beginClipAndDrawSourceImage): (WebCore::FilterImageTargetSwitcher::endClipAndDrawSourceImage): (WebCore::FilterImageTargetSwitcher::endDrawSourceImage): (WebCore::FilterImageTargetSwitcher::didDrawSourceImage): Deleted. * Source/WebCore/platform/graphics/filters/FilterImageTargetSwitcher.h: * Source/WebCore/platform/graphics/filters/FilterStyleTargetSwitcher.cpp: Copied from Source/WebCore/platform/graphics/filters/FilterTargetSwitcher.cpp. (WebCore::FilterStyleTargetSwitcher::FilterStyleTargetSwitcher): (WebCore::FilterStyleTargetSwitcher::beginDrawSourceImage): (WebCore::FilterStyleTargetSwitcher::endDrawSourceImage): * Source/WebCore/platform/graphics/filters/FilterStyleTargetSwitcher.h: Copied from Source/WebCore/platform/graphics/filters/FilterImageTargetSwitcher.h. * Source/WebCore/platform/graphics/filters/FilterTargetSwitcher.cpp: (WebCore::FilterTargetSwitcher::create): (WebCore::FilterTargetSwitcher::willDrawSourceImage): Deleted. (WebCore::FilterTargetSwitcher::didDrawSourceImage): Deleted. * Source/WebCore/platform/graphics/filters/FilterTargetSwitcher.h: (WebCore::FilterTargetSwitcher::needsRedrawSourceImage const): (WebCore::FilterTargetSwitcher::beginClipAndDrawSourceImage): (WebCore::FilterTargetSwitcher::endClipAndDrawSourceImage): (WebCore::FilterTargetSwitcher::beginDrawSourceImage): (WebCore::FilterTargetSwitcher::endDrawSourceImage): (WebCore::FilterTargetSwitcher::needsRedrawSourceImage): Deleted. * Source/WebCore/rendering/RenderLayerFilters.cpp: (WebCore::RenderLayerFilters::beginFilterEffect): (WebCore::RenderLayerFilters::applyFilterEffect): Canonical link: https://commits.webkit.org/257104@main
webkit-early-warning-system
force-pushed
the
eng/Filters-Add-an-internal-feature-key-for-enabling-GraphicsContext-filters
branch
from
e4407b3
to
ba14273
Compare
|
Committed 257104@main (ba14273): https://commits.webkit.org/257104@main Reviewed commits have been landed. Closing PR #6906 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
shallawa
deleted the
eng/Filters-Add-an-internal-feature-key-for-enabling-GraphicsContext-filters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ba14273
e4407b3
🛠 🧪 win🛠 gtk🛠 wincairo🧪 ios-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🛠 tv-sim🧪 mac-wk2🧪 mac-AS-debug-wk2