Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some more "softlinked wrapper" classes across to the new CoreIPC serialization format #6923

Conversation

gavin-apple
Copy link
Contributor

@gavin-apple gavin-apple commented Nov 29, 2022

7303ffa

Move some more "softlinked wrapper" classes across to the new CoreIPC serialization format
https://bugs.webkit.org/show_bug.cgi?id=248474
rdar://102772747

Reviewed by Alex Christensen.

    Move some more of the softlinked wrapper classes across to the new
    CoreIPC serialization format. This includes:
        - PaymentSetupFeatures
        - PaymentSetupConfiguration
        - DataDetectionResult
        - RevealItem
        - WebPopupItem

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/PlatformMac.cmake:
* Source/WebKit/Shared/ApplePay/ApplePayPaymentSetupFeatures.mm:
(WebKit::PaymentSetupFeatures::encode const): Deleted.
(WebKit::PaymentSetupFeatures::decode): Deleted.
* Source/WebKit/Shared/ApplePay/ApplePayPaymentSetupFeaturesWebKit.h:
* Source/WebKit/Shared/ApplePay/PaymentSetupConfiguration.mm:
(WebKit::PaymentSetupConfiguration::encode const): Deleted.
(WebKit::PaymentSetupConfiguration::decode): Deleted.
* Source/WebKit/Shared/ApplePay/PaymentSetupConfigurationWebKit.h:
* Source/WebKit/Shared/Cocoa/DataDetectionResult.h:
* Source/WebKit/Shared/Cocoa/DataDetectionResult.mm: Removed.
* Source/WebKit/Shared/Cocoa/RevealItem.h:
* Source/WebKit/Shared/Cocoa/RevealItem.mm:
(WebKit::RevealItem::encode const): Deleted.
(WebKit::RevealItem::decode): Deleted.
* Source/WebKit/Shared/WebPopupItem.cpp:
(WebKit::WebPopupItem::encode const): Deleted.
(WebKit::WebPopupItem::decode): Deleted.
* Source/WebKit/Shared/WebPopupItem.h:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/257254@main

1c3d127

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe
βœ… πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ api-mac ❌ πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk1
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  watch ❌ πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress

@gavin-apple gavin-apple self-assigned this Nov 29, 2022
@gavin-apple gavin-apple added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Nov 29, 2022
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 29, 2022
@gavin-apple gavin-apple force-pushed the eng/Move-some-more-softlinked-wrapper-classes-across-to-the-new-CoreIPC-serialization-format branch from ec8b299 to 1c3d127 Compare November 29, 2022 22:48
@gavin-apple gavin-apple removed the merging-blocked Applied to prevent a change from being merged label Nov 30, 2022
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 30, 2022
@achristensen07 achristensen07 added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Dec 1, 2022
… serialization format

https://bugs.webkit.org/show_bug.cgi?id=248474
rdar://102772747

Reviewed by Alex Christensen.

    Move some more of the softlinked wrapper classes across to the new
    CoreIPC serialization format. This includes:
        - PaymentSetupFeatures
        - PaymentSetupConfiguration
        - DataDetectionResult
        - RevealItem
        - WebPopupItem

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/PlatformMac.cmake:
* Source/WebKit/Shared/ApplePay/ApplePayPaymentSetupFeatures.mm:
(WebKit::PaymentSetupFeatures::encode const): Deleted.
(WebKit::PaymentSetupFeatures::decode): Deleted.
* Source/WebKit/Shared/ApplePay/ApplePayPaymentSetupFeaturesWebKit.h:
* Source/WebKit/Shared/ApplePay/PaymentSetupConfiguration.mm:
(WebKit::PaymentSetupConfiguration::encode const): Deleted.
(WebKit::PaymentSetupConfiguration::decode): Deleted.
* Source/WebKit/Shared/ApplePay/PaymentSetupConfigurationWebKit.h:
* Source/WebKit/Shared/Cocoa/DataDetectionResult.h:
* Source/WebKit/Shared/Cocoa/DataDetectionResult.mm: Removed.
* Source/WebKit/Shared/Cocoa/RevealItem.h:
* Source/WebKit/Shared/Cocoa/RevealItem.mm:
(WebKit::RevealItem::encode const): Deleted.
(WebKit::RevealItem::decode): Deleted.
* Source/WebKit/Shared/WebPopupItem.cpp:
(WebKit::WebPopupItem::encode const): Deleted.
(WebKit::WebPopupItem::decode): Deleted.
* Source/WebKit/Shared/WebPopupItem.h:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/257254@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Move-some-more-softlinked-wrapper-classes-across-to-the-new-CoreIPC-serialization-format branch from 1c3d127 to 7303ffa Compare December 1, 2022 21:32
@webkit-commit-queue
Copy link
Collaborator

Committed 257254@main (7303ffa): https://commits.webkit.org/257254@main

Reviewed commits have been landed. Closing PR #6923 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 7303ffa into WebKit:main Dec 1, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit Process Model Bugs related to WebKit's multi-process architecture
Projects
None yet
5 participants