-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some more "softlinked wrapper" classes across to the new CoreIPC serialization format #6923
Merged
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
gavin-apple:eng/Move-some-more-softlinked-wrapper-classes-across-to-the-new-CoreIPC-serialization-format
Dec 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavin-apple
added
the
WebKit Process Model
Bugs related to WebKit's multi-process architecture
label
Nov 29, 2022
EWS run on previous version of this PR (hash ec8b299) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Nov 29, 2022
gavin-apple
force-pushed
the
eng/Move-some-more-softlinked-wrapper-classes-across-to-the-new-CoreIPC-serialization-format
branch
from
November 29, 2022 22:48
ec8b299
to
1c3d127
Compare
EWS run on current version of this PR (hash 1c3d127) |
gavin-apple
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Nov 30, 2022
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Nov 30, 2022
achristensen07
approved these changes
Dec 1, 2022
achristensen07
added
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
and removed
merging-blocked
Applied to prevent a change from being merged
labels
Dec 1, 2022
β¦ serialization format https://bugs.webkit.org/show_bug.cgi?id=248474 rdar://102772747 Reviewed by Alex Christensen. Move some more of the softlinked wrapper classes across to the new CoreIPC serialization format. This includes: - PaymentSetupFeatures - PaymentSetupConfiguration - DataDetectionResult - RevealItem - WebPopupItem * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/PlatformMac.cmake: * Source/WebKit/Shared/ApplePay/ApplePayPaymentSetupFeatures.mm: (WebKit::PaymentSetupFeatures::encode const): Deleted. (WebKit::PaymentSetupFeatures::decode): Deleted. * Source/WebKit/Shared/ApplePay/ApplePayPaymentSetupFeaturesWebKit.h: * Source/WebKit/Shared/ApplePay/PaymentSetupConfiguration.mm: (WebKit::PaymentSetupConfiguration::encode const): Deleted. (WebKit::PaymentSetupConfiguration::decode): Deleted. * Source/WebKit/Shared/ApplePay/PaymentSetupConfigurationWebKit.h: * Source/WebKit/Shared/Cocoa/DataDetectionResult.h: * Source/WebKit/Shared/Cocoa/DataDetectionResult.mm: Removed. * Source/WebKit/Shared/Cocoa/RevealItem.h: * Source/WebKit/Shared/Cocoa/RevealItem.mm: (WebKit::RevealItem::encode const): Deleted. (WebKit::RevealItem::decode): Deleted. * Source/WebKit/Shared/WebPopupItem.cpp: (WebKit::WebPopupItem::encode const): Deleted. (WebKit::WebPopupItem::decode): Deleted. * Source/WebKit/Shared/WebPopupItem.h: * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/257254@main
webkit-early-warning-system
force-pushed
the
eng/Move-some-more-softlinked-wrapper-classes-across-to-the-new-CoreIPC-serialization-format
branch
from
December 1, 2022 21:32
1c3d127
to
7303ffa
Compare
Committed 257254@main (7303ffa): https://commits.webkit.org/257254@main Reviewed commits have been landed. Closing PR #6923 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7303ffa
1c3d127