Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSC] Disable ArrayBuffer#transfer #6928

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Nov 29, 2022

458fd47

[JSC] Disable ArrayBuffer#transfer
https://bugs.webkit.org/show_bug.cgi?id=248484
rdar://102775650

Reviewed by Mark Lam.

ArrayBuffer#transfer's semantics is still under discussion, and TC39 decided separating this out from
the rest of resizable ArrayBuffer, and creating a new proposal for ArrayBuffer#transfer.
We disable ArrayBuffer#transfer to follow to this.

[1]: tc39/proposal-arraybuffer-transfer#4

* JSTests/ChakraCore/test/typedarray/arraybufferType.baseline-jsc:
* JSTests/stress/v8-harmony-arraybuffer-transfer.js:
* JSTests/test262/config.yaml:
* Source/JavaScriptCore/runtime/JSArrayBufferPrototype.cpp:
(JSC::JSArrayBufferPrototype::finishCreation):
* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/257162@main

f83eb2c

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2 βœ… πŸ›  mac-AS-debug   πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios   πŸ§ͺ api-mac   πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ›  tv   πŸ§ͺ mac-wk1 βœ… πŸ›  jsc-armv7
βœ… πŸ›  tv-sim   πŸ§ͺ mac-wk2 βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch   πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ›  jsc-mips
βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ§ͺ jsc-mips-tests

@Constellation Constellation requested a review from a team as a code owner November 29, 2022 19:24
@Constellation Constellation self-assigned this Nov 29, 2022
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Nov 29, 2022
Copy link

@MenloDorian MenloDorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation
Copy link
Member Author

macOS EWS bots are getting stuck and not working in a reasonable time period.

@Constellation Constellation added the merge-queue Applied to send a pull request to merge-queue label Nov 30, 2022
https://bugs.webkit.org/show_bug.cgi?id=248484
rdar://102775650

Reviewed by Mark Lam.

ArrayBuffer#transfer's semantics is still under discussion, and TC39 decided separating this out from
the rest of resizable ArrayBuffer, and creating a new proposal for ArrayBuffer#transfer.
We disable ArrayBuffer#transfer to follow to this.

[1]: https://github.com/tc39/proposal-resizablearraybuffer/issues/113

* JSTests/ChakraCore/test/typedarray/arraybufferType.baseline-jsc:
* JSTests/stress/v8-harmony-arraybuffer-transfer.js:
* JSTests/test262/config.yaml:
* Source/JavaScriptCore/runtime/JSArrayBufferPrototype.cpp:
(JSC::JSArrayBufferPrototype::finishCreation):
* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/257162@main
@webkit-commit-queue
Copy link
Collaborator

Committed 257162@main (458fd47): https://commits.webkit.org/257162@main

Reviewed commits have been landed. Closing PR #6928 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 458fd47 into WebKit:main Nov 30, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
4 participants