Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cues displayed during end time #694

Merged
merged 0 commits into from Jun 17, 2022
Merged

Cues displayed during end time #694

merged 0 commits into from Jun 17, 2022

Conversation

youssefsoli
Copy link
Contributor

@youssefsoli youssefsoli commented May 17, 2022 •
edited by webkit-commit-queue

74911f7

Cues displayed during end time
https://bugs.webkit.org/show_bug.cgi?id=221854
<rdar://problem/74541188>

Patch by Youssef Soliman <youssefdevelops@gmail.com> on 2022-06-17
Reviewed by Eric Carlson.

Fixed edge case with cue intervals that had end times that coincided
with the current media time in order to follow the spec.

Test: media/track/track-cue-endtime.html
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
* LayoutTests/media/track/track-cue-endtime-expected.txt: Added.
* LayoutTests/media/track/track-cue-endtime.html: Added.

Canonical link: https://commits.webkit.org/251652@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@youssefsoli youssefsoli added Media Bugs related to the HTML 5 Media elements. Safari 14 labels May 17, 2022
@youssefsoli youssefsoli force-pushed the eng/Cues-displayed-during-end-time branch from 79438a2 to db79cd3 Compare May 17, 2022 21:39
joeyparrish
joeyparrish approved these changes May 17, 2022
View reviewed changes
Copy link

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my project, but I approve! 👍

@youssefsoli youssefsoli self-assigned this May 17, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 17, 2022
@eric-carlson eric-carlson self-requested a review May 18, 2022 00:06
eric-carlson
eric-carlson approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@eric-carlson eric-carlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@youssefsoli youssefsoli removed the merging-blocked Applied to prevent a change from being merged label May 18, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 19, 2022
@youssefsoli youssefsoli removed the merging-blocked Applied to prevent a change from being merged label May 20, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 21, 2022
@youssefsoli youssefsoli removed the merging-blocked Applied to prevent a change from being merged label May 26, 2022
@youssefsoli youssefsoli force-pushed the eng/Cues-displayed-during-end-time branch from db79cd3 to 2faf253 Compare June 6, 2022 22:27
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jun 7, 2022
@youssefsoli youssefsoli force-pushed the eng/Cues-displayed-during-end-time branch from 2faf253 to fee41ee Compare June 8, 2022 16:41
@youssefsoli youssefsoli removed the merging-blocked Applied to prevent a change from being merged label Jun 8, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jun 8, 2022
@youssefsoli youssefsoli force-pushed the eng/Cues-displayed-during-end-time branch from fee41ee to 509a781 Compare June 17, 2022 18:25
@youssefsoli youssefsoli removed the merging-blocked Applied to prevent a change from being merged label Jun 17, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jun 17, 2022
@youssefsoli youssefsoli force-pushed the eng/Cues-displayed-during-end-time branch from 509a781 to be68a09 Compare June 17, 2022 20:34
@youssefsoli youssefsoli removed the merging-blocked Applied to prevent a change from being merged label Jun 17, 2022
@eric-carlson eric-carlson added the merge-queue Applied to send a pull request to merge-queue label Jun 17, 2022
@webkit-commit-queue webkit-commit-queue merged commit 74911f7 into WebKit:main Jun 17, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed r295647 (251652@main): https://commits.webkit.org/251652@main

Reviewed commits have been landed. Closing PR #694 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-carlson eric-carlson eric-carlson approved these changes

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees

@youssefsoli youssefsoli

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
5 participants
@youssefsoli @webkit-commit-queue @eric-carlson @joeyparrish @webkit-early-warning-system