Add a 'status' field to feature flags denoting their use case #6945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash 5dbe895) |
brentfulgham
approved these changes
Nov 29, 2022
| statuses = ["embedder", "unstable", "internal", "developer", "testable", "preview", "stable"] | ||
| options["status"] ||= defaultStatus | ||
| if !statuses.include? options["status"] | ||
| raise "ERROR: #{options["status"]} not one of the known statuses: #{statuses}" |
There was a problem hiding this comment.
Thank you for this logging -- I was worried about typos!
webkit-early-warning-system
force-pushed
the
eng/feature-status-field
branch
from
5dbe895
to
72ad7c4
Compare
https://bugs.webkit.org/show_bug.cgi?id=247926 rdar://92112770 Reviewed by Brent Fulgham. Add enum types representing different semantic labels for feature flags. Add status fields to our various feature flag types: - Cross-platform WebKit: API::ExperimentalFeature.status() and API::InternalDebugFeature.status() - Cocoa WebKit SPI: -[_WKExperimentalFeature status] and -[_WKInternalDebugFeature status] - WebKitLegacy: -[WebFeature status] Update GeneratePreferences.rb to read a "status" field from WebPreferences yamls, and update its templates to pass this through to the feature instantiation site. Currently, individual preferences do not declare their own status; instead, the generator picks an appropriate status based on which file the preference is declared in. Eventually, we will merge these files into a single preferences manifest, and use the status field to determine where a feature gets exposed. * Source/WTF/Scripts/GeneratePreferences.rb: * Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb: * Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesInternalDebugFeatures.cpp.erb: * Source/WebKit/UIProcess/API/APIExperimentalFeature.cpp: (API::ExperimentalFeature::create): (API::ExperimentalFeature::ExperimentalFeature): * Source/WebKit/UIProcess/API/APIExperimentalFeature.h: * Source/WebKit/UIProcess/API/APIFeatureStatus.h: Copied from Source/WebKitLegacy/mac/WebView/WebFeatureInternal.h. * Source/WebKit/UIProcess/API/APIInternalDebugFeature.cpp: (API::InternalDebugFeature::create): (API::InternalDebugFeature::InternalDebugFeature): * Source/WebKit/UIProcess/API/APIInternalDebugFeature.h: * Source/WebKit/UIProcess/API/Cocoa/_WKExperimentalFeature.h: * Source/WebKit/UIProcess/API/Cocoa/_WKExperimentalFeature.mm: (-[_WKExperimentalFeature status]): * Source/WebKit/UIProcess/API/Cocoa/_WKInternalDebugFeature.h: * Source/WebKit/UIProcess/API/Cocoa/_WKInternalDebugFeature.mm: (-[_WKInternalDebugFeature status]): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb: * Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesInternalFeatures.mm.erb: * Source/WebKitLegacy/mac/WebView/WebFeature.h: * Source/WebKitLegacy/mac/WebView/WebFeature.m: (-[WebFeature initWithKey:preferenceKey:name:status:details:defaultValue:hidden:]): (-[WebFeature initWithKey:preferenceKey:name:details:defaultValue:hidden:]): Deleted. * Source/WebKitLegacy/mac/WebView/WebFeatureInternal.h: Canonical link: https://commits.webkit.org/257166@main
webkit-early-warning-system
force-pushed
the
eng/feature-status-field
branch
from
72ad7c4
to
429cc4c
Compare
|
Committed 257166@main (429cc4c): https://commits.webkit.org/257166@main Reviewed commits have been landed. Closing PR #6945 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
429cc4c
5dbe895
🛠 gtk🧪 ios-wk2🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2