[JSC] Update resizable ArrayBuffer based on spec update #6956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
|
EWS run on current version of this PR (hash 78558b5) |
rkirsling
approved these changes
Nov 30, 2022
| // https://tc39.es/proposal-resizablearraybuffer/#sec-isarraybufferviewoutofbounds | ||
| if (UNLIKELY(isDetached())) | ||
| return true; | ||
| if (LIKELY(!isResizableNonShared())) |
There was a problem hiding this comment.
Seems like this is a SAB check in the spec text—do we have some additional assumption at play?
There was a problem hiding this comment.
There are three arrays,
- resizable
- growable
- normal
And only (1) can be OOB status. (2) is growing only, and (3) is valid or detached.
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=248511 rdar://102793557 Reviewed by Ross Kirsling. * LayoutTests/js/dom/resizable-array-buffer-view-serialization-out-of-bounds-expected.txt: * LayoutTests/js/dom/resizable-array-buffer-view-serialization-out-of-bounds-explicit-length-expected.txt: * LayoutTests/js/dom/resizable-array-buffer-view-serialization-out-of-bounds-explicit-length.html: * LayoutTests/js/dom/resizable-array-buffer-view-serialization-out-of-bounds.html: * LayoutTests/js/dom/resizable-data-view-serialization-out-of-bounds-expected.txt: Added. * LayoutTests/js/dom/resizable-data-view-serialization-out-of-bounds-explicit-length-expected.txt: Added. * LayoutTests/js/dom/resizable-data-view-serialization-out-of-bounds-explicit-length.html: Copied from LayoutTests/js/dom/resizable-array-buffer-view-serialization-out-of-bounds-explicit-length.html. * LayoutTests/js/dom/resizable-data-view-serialization-out-of-bounds.html: Copied from LayoutTests/js/dom/resizable-array-buffer-view-serialization-out-of-bounds.html. * Source/JavaScriptCore/runtime/JSArrayBufferView.h: (JSC::JSArrayBufferView::isDetached const): (JSC::JSArrayBufferView::byteOffset const): (JSC::JSArrayBufferView::isOutOfBounds const): Add isOutOfBounds, function aligned to spec's IsArrayBufferViewOutOfBounds. Used in SerializedScriptValue. (JSC::JSArrayBufferView::isDetached): Deleted. * Source/JavaScriptCore/runtime/JSArrayBufferViewInlines.h: (JSC::isArrayBufferViewOutOfBounds): (JSC::isIntegerIndexedObjectOutOfBounds): * Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h: (JSC::genericTypedArrayViewProtoFuncSet): This is not actually changing the behavior, but more aligned to the latest spec's change. * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpArrayBufferView): We reject OOB ArrayBuffer based on discussion in [1]. [1]: whatwg/html#8559 Canonical link: https://commits.webkit.org/257178@main
webkit-early-warning-system
force-pushed
the
eng/JSC-Update-resizable-ArrayBuffer-based-on-spec-update
branch
from
78558b5
to
ba8ba25
Compare
|
Committed 257178@main (ba8ba25): https://commits.webkit.org/257178@main Reviewed commits have been landed. Closing PR #6956 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Constellation
deleted the
eng/JSC-Update-resizable-ArrayBuffer-based-on-spec-update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ba8ba25
78558b5
🛠 gtk🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2