Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unified build of LibWebRTCProviderGStreamer #6968

Merged
merged 1 commit into from Dec 12, 2022
Merged

Fix unified build of LibWebRTCProviderGStreamer #6968

merged 1 commit into from Dec 12, 2022

Conversation

blino
Copy link
Contributor

@blino blino commented Nov 30, 2022 •
edited by webkit-early-warning-system

@blino blino requested a review from philn as a code owner November 30, 2022 14:40
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 0d61a70)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ❌ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
❌ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 1, 2022
@philn philn added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Dec 9, 2022
@blino blino force-pushed the eng/Fix-unified-build-of-LibWebRTCProviderGStreamer branch from 0d61a70 to af7072a Compare December 12, 2022 13:47
@philn philn added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Dec 12, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash af7072a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings   🛠 ios-sim ✅ 🛠 mac-AS-debug   🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@blino @philn
Fix unified build of LibWebRTCProviderGStreamer
e60aeb1 
https://bugs.webkit.org/show_bug.cgi?id=248532

Reviewed by Youenn Fablet.

* Source/WebCore/platform/mediastream/libwebrtc/gstreamer/LibWebRTCProviderGStreamer.h: LibWebRTCProvider.h needs to be included

Canonical link: https://commits.webkit.org/257726@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-unified-build-of-LibWebRTCProviderGStreamer branch from af7072a to e60aeb1 Compare December 12, 2022 14:43
@webkit-commit-queue
Copy link
Collaborator

Committed 257726@main (e60aeb1): https://commits.webkit.org/257726@main

Reviewed commits have been landed. Closing PR #6968 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 12, 2022
@webkit-commit-queue webkit-commit-queue merged commit e60aeb1 into WebKit:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youennf youennf youennf approved these changes

@philn philn Awaiting requested review from philn philn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@blino @webkit-early-warning-system @webkit-commit-queue @youennf @philn @webkit-ews-buildbot