Closing ARQL results in an empty view with a spinner #6974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grorg
added
the
WebKit Misc.
|
EWS run on current version of this PR (hash 0cbb84d)
|
graouts
approved these changes
Nov 30, 2022
grorg
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=248538 rdar://102379447 Reviewed by Antoine Quint. ARQL compares the URL we give it at the start of a download to the one we give it at the end. The latter one has the fragment identifier appended, and unfortunately ARQL does a string comparison. This causes it to think it is opening two different files, resulting in a spinner spinning forever. * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: Remove the fragment identifier before sending it to ARQL. Canonical link: https://commits.webkit.org/257188@main
webkit-early-warning-system
force-pushed
the
eng/Closing-ARQL-results-in-an-empty-view-with-a-spinner
branch
from
0cbb84d
to
ca06823
Compare
|
Committed 257188@main (ca06823): https://commits.webkit.org/257188@main Reviewed commits have been landed. Closing PR #6974 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
grorg
deleted the
eng/Closing-ARQL-results-in-an-empty-view-with-a-spinner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ca06823
0cbb84d
🛠 gtk🛠 wincairo🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🛠 tv-sim🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress