Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPE][GTK] generate-pdfjs-gresource-manifest.py should be more careful about unknown files #700

Closed
wants to merge 4 commits into from
Closed

[WPE][GTK] generate-pdfjs-gresource-manifest.py should be more careful about unknown files #700

wants to merge 4 commits into from

Conversation

mcatanzaro
Copy link
Contributor

@mcatanzaro mcatanzaro commented May 17, 2022 •
edited by webkit-early-warning-system

6a288a6

[WPE][GTK] generate-pdfjs-gresource-manifest.py should be more careful about unknown files
https://bugs.webkit.org/show_bug.cgi?id=240536

Patch by Michael Catanzaro <mcatanzaro@redhat.com > on 2022-05-17
Reviewed by Adrian Perez de Castro.

Instead of silently ignoring unexpected files, let's create a list of
all files that we do not want to include in the resource manifest.
Anything unexpected will result in a build failure so that there are no
mistakes.

Also, change the lists at the top of the script into sets. Adrian
noticed that they do not need to be ordered.

* Tools/glib/generate-pdfjs-gresource-manifest.py:
(get_filenames):
(get_filenames.should_ignore_resource): Deleted.

Canonical link: https://commits.webkit.org/250671@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@mcatanzaro mcatanzaro self-assigned this May 17, 2022
@mcatanzaro mcatanzaro added PDF For bugs in WebKit's built-in PDF support. WebKit Nightly Build labels May 17, 2022
@mcatanzaro mcatanzaro requested a review from aperezdc May 17, 2022 22:46
@mcatanzaro mcatanzaro force-pushed the eng/WPEGTK-generate-pdfjs-gresource-manifest-py-should-be-more-careful-about-unknown-files branch from 6e598cd to 10a0627 Compare May 17, 2022 22:48
aperezdc
aperezdc approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@aperezdc aperezdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tools/glib/generate-pdfjs-gresource-manifest.py Outdated Show resolved Hide resolved
@mcatanzaro mcatanzaro force-pushed the eng/WPEGTK-generate-pdfjs-gresource-manifest-py-should-be-more-careful-about-unknown-files branch from 10a0627 to f3bbf24 Compare May 17, 2022 23:30
@mcatanzaro mcatanzaro added the merge-queue Applied to send a pull request to merge-queue label May 18, 2022
zhifei_fang@apple.com and others added 4 commits May 18, 2022 01:37
[git-webkit] Make git-webkit revert a two step workflow
3767899 
https://bugs.webkit.org/show_bug.cgi?id=240192
rdar://92875608

Reviewed by Jonathan Bedard.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.create_pull_request):
(PullRequest.add_comment_to_reverted_commit_bug_tracker):
(PullRequest.is_revert_commit):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py:
(Revert):
(Revert.parser):
(Revert.revert_commit):
(Revert.main):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py:
(TestRevert.test_github):
(test_update):

Canonical link: https://commits.webkit.org/250668@main


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
@basuke
[WinCairo] Add memory usage of LibcMalloc category
d769582 
https://bugs.webkit.org/show_bug.cgi?id=239660

Reviewed by Ross Kirsling.

WinCairo's memory timeline just displays JavaScript memory usage. Adding
this info shows also Page
memory usage.

* page/win/ResourceUsageThreadWin.cpp:
(WebCore::ResourceUsageThread::platformCollectMemoryData):

Canonical link: https://commits.webkit.org/250669@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
@aproskuryakov
Reverting https://trac.webkit.org/r294367, as some of our automation …
e7eb8dd 
…hosts don't

have the --date=unix option.

Reviewed by NOBODY (OOPS!).

* Scripts/libraries/webkitscmpy/setup.py:
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:
* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.Cache.populate):
(Git.commit):
(Git._args_from_content):
(Git.commits):
* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
* Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
(TestGit.test_log):

Canonical link: https://commits.webkit.org/250670@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
@mcatanzaro @webkit-commit-queue
[WPE][GTK] generate-pdfjs-gresource-manifest.py should be more carefu…
6a288a6 
…l about unknown files

https://bugs.webkit.org/show_bug.cgi?id=240536

Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-05-17
Reviewed by Adrian Perez de Castro.

Instead of silently ignoring unexpected files, let's create a list of
all files that we do not want to include in the resource manifest.
Anything unexpected will result in a build failure so that there are no
mistakes.

Also, change the lists at the top of the script into sets. Adrian
noticed that they do not need to be ordered.

* Tools/glib/generate-pdfjs-gresource-manifest.py:
(get_filenames):
(get_filenames.should_ignore_resource): Deleted.

Canonical link: https://commits.webkit.org/250671@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/WPEGTK-generate-pdfjs-gresource-manifest-py-should-be-more-careful-about-unknown-files branch from f3bbf24 to 6a288a6 Compare May 18, 2022 01:46
@webkit-early-warning-system
Copy link
Collaborator

Committed r294379 (250671@main): https://commits.webkit.org/250671@main

Reviewed commits have been landed. Closing PR #700 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 18, 2022
@mcatanzaro mcatanzaro deleted the eng/WPEGTK-generate-pdfjs-gresource-manifest-py-should-be-more-careful-about-unknown-files branch July 7, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aperezdc aperezdc aperezdc approved these changes

Assignees

@mcatanzaro mcatanzaro

Labels
PDF For bugs in WebKit's built-in PDF support.
Projects
None yet
Milestone
No milestone
5 participants
@mcatanzaro @webkit-early-warning-system @aperezdc @basuke @aproskuryakov