Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove macOS-AppleSilicon-Big-Sur-Debug-* Queues #7004

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

https://bugs.webkit.org/show_bug.cgi?id=248576
rdar://102836381

Reviewed by NOBODY (OOPS!).

Explanation of why this fixes the bug (OOPS!).

* Tools/CISupport/ews-build/config.json:
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
@chgibb-apple chgibb-apple self-assigned this Dec 1, 2022
@chgibb-apple chgibb-apple added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Dec 1, 2022
Copy link
Member

@JonWBedard JonWBedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although it looks like @ddkilzer landed his change adding an explanation template, so you'll need to either delete that or add an explanation, because OOPS will prevent landing.

@aj062
Copy link
Member

aj062 commented Dec 1, 2022

why are these queues being removed?

Also, neither the bug, nor this PR mention the reason, in general that reason for the change (unless it's very obvious) should be mentioned.

@chgibb-apple chgibb-apple added the merge-queue Applied to send a pull request to merge-queue label Dec 1, 2022
@webkit-commit-queue
Copy link
Collaborator

Commit message contains (OOPS!), blocking PR #7004

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Dec 1, 2022
Copy link
Member

@aj062 aj062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need AppleSilicon queues on EWS. Unless there is a strong reason we shouldn't remove these queues. To update the OS/configuration, we can add remove old one and add new queues in same PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merging-blocked Applied to prevent a change from being merged Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
5 participants