New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove macOS-AppleSilicon-Big-Sur-Debug-* Queues #7004
base: main
Are you sure you want to change the base?
Conversation
https://bugs.webkit.org/show_bug.cgi?id=248576 rdar://102836381 Reviewed by NOBODY (OOPS!). Explanation of why this fixes the bug (OOPS!). * Tools/CISupport/ews-build/config.json: * Tools/CISupport/ews-build/factories_unittest.py: (TestExpectedBuildSteps):
EWS run on current version of this PR (hash 7ae3d83) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although it looks like @ddkilzer landed his change adding an explanation template, so you'll need to either delete that or add an explanation, because OOPS
will prevent landing.
why are these queues being removed? Also, neither the bug, nor this PR mention the reason, in general that reason for the change (unless it's very obvious) should be mentioned. |
Commit message contains (OOPS!), blocking PR #7004 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need AppleSilicon queues on EWS. Unless there is a strong reason we shouldn't remove these queues. To update the OS/configuration, we can add remove old one and add new queues in same PR.
7ae3d83
7ae3d83