Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WritableStreamDefaultController signal getter #7022

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Dec 1, 2022

5815663

Add WritableStreamDefaultController signal getter
https://bugs.webkit.org/show_bug.cgi?id=248600
rdar://problem/102858374

Reviewed by Alex Christensen.

Add signal as attribute and signal it as aborted when stream gets aborted.
Add necessary built-in globals to interact with AbortSignal.
Covered by rebased tests.

* LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any.serviceworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any.worker-expected.txt:
* Source/WebCore/Modules/streams/WritableStreamDefaultController.idl:
* Source/WebCore/Modules/streams/WritableStreamDefaultController.js:
(getter.signal):
* Source/WebCore/Modules/streams/WritableStreamInternals.js:
(writableStreamAbort):
(setUpWritableStreamDefaultController):
* Source/WebCore/bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:

Canonical link: https://commits.webkit.org/257397@main

692cb1c

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe ❌ πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim ❌ πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  watch-sim

@youennf youennf self-assigned this Dec 1, 2022
@youennf youennf added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Dec 1, 2022
Source/WebCore/dom/AbortSignal.idl Outdated Show resolved Hide resolved
@youennf youennf force-pushed the eng/Add-WritableStreamDefaultController-signal-getter branch from 7414e93 to 692cb1c Compare December 4, 2022 20:03
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 5, 2022
@youennf youennf added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Dec 6, 2022
https://bugs.webkit.org/show_bug.cgi?id=248600
rdar://problem/102858374

Reviewed by Alex Christensen.

Add signal as attribute and signal it as aborted when stream gets aborted.
Add necessary built-in globals to interact with AbortSignal.
Covered by rebased tests.

* LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any.serviceworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any.worker-expected.txt:
* Source/WebCore/Modules/streams/WritableStreamDefaultController.idl:
* Source/WebCore/Modules/streams/WritableStreamDefaultController.js:
(getter.signal):
* Source/WebCore/Modules/streams/WritableStreamInternals.js:
(writableStreamAbort):
(setUpWritableStreamDefaultController):
* Source/WebCore/bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:

Canonical link: https://commits.webkit.org/257397@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Add-WritableStreamDefaultController-signal-getter branch from 692cb1c to 5815663 Compare December 6, 2022 08:33
@webkit-early-warning-system webkit-early-warning-system merged commit 5815663 into WebKit:main Dec 6, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 257397@main (5815663): https://commits.webkit.org/257397@main

Reviewed commits have been landed. Closing PR #7022 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
5 participants