New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WritableStreamDefaultController signal getter #7022
Merged
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
youennf:eng/Add-WritableStreamDefaultController-signal-getter
Dec 6, 2022
Merged
Add WritableStreamDefaultController signal getter #7022
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
youennf:eng/Add-WritableStreamDefaultController-signal-getter
Dec 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youennf
added
the
WebCore Misc.
For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
label
Dec 1, 2022
EWS run on previous version of this PR (hash 7414e93) |
achristensen07
approved these changes
Dec 1, 2022
youennf
force-pushed
the
eng/Add-WritableStreamDefaultController-signal-getter
branch
from
December 4, 2022 20:03
7414e93
to
692cb1c
Compare
EWS run on current version of this PR (hash 692cb1c) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Dec 5, 2022
youennf
added
merge-queue
Applied to send a pull request to merge-queue
and removed
merging-blocked
Applied to prevent a change from being merged
labels
Dec 6, 2022
https://bugs.webkit.org/show_bug.cgi?id=248600 rdar://problem/102858374 Reviewed by Alex Christensen. Add signal as attribute and signal it as aborted when stream gets aborted. Add necessary built-in globals to interact with AbortSignal. Covered by rebased tests. * LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any.serviceworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any.worker-expected.txt: * Source/WebCore/Modules/streams/WritableStreamDefaultController.idl: * Source/WebCore/Modules/streams/WritableStreamDefaultController.js: (getter.signal): * Source/WebCore/Modules/streams/WritableStreamInternals.js: (writableStreamAbort): (setUpWritableStreamDefaultController): * Source/WebCore/bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSC_DEFINE_HOST_FUNCTION): (WebCore::JSDOMGlobalObject::addBuiltinGlobals): * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: Canonical link: https://commits.webkit.org/257397@main
webkit-early-warning-system
force-pushed
the
eng/Add-WritableStreamDefaultController-signal-getter
branch
from
December 6, 2022 08:33
692cb1c
to
5815663
Compare
Committed 257397@main (5815663): https://commits.webkit.org/257397@main Reviewed commits have been landed. Closing PR #7022 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
WebCore Misc.
For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5815663
692cb1c