[GTK] gsk_renderer_render_texture: assertion 'GSK_IS_RENDER_NODE (root)' failed in webkitWebViewBaseTakeViewSnapshot #7037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash 84ba723)
|
|
Oh, this actually often happens immediately when starting Epiphany. Not always, but often. It can also happen randomly during normal browsing. |
carlosgcampos
approved these changes
Dec 2, 2022
carlosgcampos
added
the
unsafe-merge-queue
…t)' failed in webkitWebViewBaseTakeViewSnapshot https://bugs.webkit.org/show_bug.cgi?id=247463 Reviewed by Carlos Garcia Campos. I don't know how to reproduce this crash, but it happens a lot and the solution is clear enough. When the snapshot is empty, then the GskRenderNode is nullptr, and we should immediately return nullptr instead of trying to use it as a valid GskRenderNode. The return value here is already nullable, so there's nothing more to worry about. I'm not certain why this happens, but I think it might be associated with web process hangs. Doesn't matter: the UI process should be robust regardless. Thanks to Benjamin Otte for helping with my questions regarding this issue. * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseTakeViewSnapshot): Canonical link: https://commits.webkit.org/257276@main
webkit-early-warning-system
force-pushed
the
eng/GTK-gsk_renderer_render_texture-assertion-GSK_IS_RENDER_NODE-root-failed-in-webkitWebViewBaseTakeViewSnapshot
branch
from
84ba723
to
fd0db7c
Compare
|
Committed 257276@main (fd0db7c): https://commits.webkit.org/257276@main Reviewed commits have been landed. Closing PR #7037 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
mcatanzaro
deleted the
eng/GTK-gsk_renderer_render_texture-assertion-GSK_IS_RENDER_NODE-root-failed-in-webkitWebViewBaseTakeViewSnapshot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fd0db7c
84ba723
🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2