Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAuthn authenticatorAttachment is always "platform" over hybrid #7178

Conversation

g-davidson
Copy link

@g-davidson g-davidson commented Dec 6, 2022

@rmondello
Copy link
Member

@pascoej will likely be interested in this one.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 6, 2022
@pascoej
Copy link
Member

pascoej commented Dec 8, 2022

From the WK POV, I wish we could just have one of ASCPublicKeyCredentialRegistration.
r+

@pascoej
Copy link
Member

pascoej commented Dec 8, 2022

@ryanhaddad mac-wk2 ran this both with and without this change and found the same test results, but the bubble is still red, is this a bug?

@pascoej pascoej added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Dec 8, 2022
https://bugs.webkit.org/show_bug.cgi?id=248800
rdar://102608692

Reviewed by J Pascoe.

At the time this was written, the type of credential implied the attachment. Now
all of the credential types have an attachment property to use instead.

Canonical link: https://commits.webkit.org/257576@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/WebAuthn-authenticatorAttachment-is-always-platform-over-hybrid branch from c704afa to f1464f7 Compare December 8, 2022 19:33
@webkit-commit-queue
Copy link
Collaborator

Committed 257576@main (f1464f7): https://commits.webkit.org/257576@main

Reviewed commits have been landed. Closing PR #7178 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit f1464f7 into WebKit:main Dec 8, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants