Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WinCairo] Build error with CMAKE_DISABLE_PRECOMPILE_HEADERS ON after 257057@main #7185

Closed
wants to merge 1 commit into from
Closed

[WinCairo] Build error with CMAKE_DISABLE_PRECOMPILE_HEADERS ON after 257057@main #7185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions Source/WebCore/platform/LocalizedStrings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@
#include <glib/gi18n-lib.h>
#endif

#if USE(CF) && PLATFORM(WIN)
#include <wtf/text/cf/StringConcatenateCF.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should #include <CoreFoundation/CFString.h>.
Why StringConcatenateCF.h?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, I will try to build using that header.

I used wtf/text/cf/StringConcatenateCF.h because by grepping source code I saw the class was defined there (although actually is not). Somehow it worked though.

There are still other build errors that's why the PR is still a draft.

#endif

namespace WebCore {

class IntSize;
Expand Down