New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform media networking operations off the main thread #719
Merged
webkit-early-warning-system
merged 0 commits into
WebKit:main
from
jyavenard:rdr/84517825
May 28, 2022
Merged
Perform media networking operations off the main thread #719
webkit-early-warning-system
merged 0 commits into
WebKit:main
from
jyavenard:rdr/84517825
May 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webkit-early-warning-system
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 18, 2022
Could you give the PR a better title? 😀 |
jyavenard
removed
the
merging-blocked
Applied to prevent a change from being merged
label
May 18, 2022
I've made it a draft :) shouldn't be visible ! |
jyavenard
changed the title
fix various builds
Run media networking operation off the main thread
May 18, 2022
webkit-early-warning-system
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 18, 2022
jyavenard
added
Media
Bugs related to the HTML 5 Media elements.
Other
and removed
merging-blocked
Applied to prevent a change from being merged
Media
Bugs related to the HTML 5 Media elements.
Other
labels
May 18, 2022
webkit-early-warning-system
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 18, 2022
jyavenard
removed
merging-blocked
Applied to prevent a change from being merged
Media
Bugs related to the HTML 5 Media elements.
Other
labels
May 19, 2022
jyavenard
changed the title
Run media networking operation off the main thread
Properly set NSURLSession to NSURLSessionTaskStateRunning when we will use the rangeResponseGenerator.
May 19, 2022
webkit-early-warning-system
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 19, 2022
jyavenard
removed
the
merging-blocked
Applied to prevent a change from being merged
label
May 20, 2022
jyavenard
changed the title
Properly set NSURLSession to NSURLSessionTaskStateRunning when we will use the rangeResponseGenerator.
Make RemoteMediaResourceManager keep a strong reference to the MediaResource and enforce shutting down the mediaresource before deleting it (to break any potential cycle)
May 20, 2022
webkit-early-warning-system
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 24, 2022
jyavenard
removed
merging-blocked
Applied to prevent a change from being merged
Media
Bugs related to the HTML 5 Media elements.
Other
labels
May 26, 2022
webkit-early-warning-system
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 26, 2022
jyavenard
removed
merging-blocked
Applied to prevent a change from being merged
Media
Bugs related to the HTML 5 Media elements.
Other
labels
May 27, 2022
webkit-early-warning-system
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 27, 2022
compositing/video/video-border-radius.html is failing 90% of the time, even without those changes with WK1 |
jyavenard
removed
merging-blocked
Applied to prevent a change from being merged
Media
Bugs related to the HTML 5 Media elements.
Other
labels
May 28, 2022
webkit-early-warning-system
force-pushed
the
rdr/84517825
branch
from
May 28, 2022 13:27
b8f3b9b
to
be35d3c
Compare
Committed r294999 (251097@main): https://commits.webkit.org/251097@main Reviewed commits have been landed. Closing PR #719 and removing active labels. |
webkit-early-warning-system
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be35d3c