Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI-side compositing] Ensure that wheel events got to the web process for JS event handlers #7234

Conversation

smfr
Copy link
Contributor

@smfr smfr commented Dec 7, 2022

066e5bd

[UI-side compositing] Ensure that wheel events got to the web process for JS event handlers
https://bugs.webkit.org/show_bug.cgi?id=248846

Reviewed by Tim Horton.

Override `eventListenerRegionTypesForPoint()` in RemoteScrollingTreeMac just as we do in ScrollingTreeMac
to get the event handler details for a given point. We use this to know if we have to continue with the
web process/main thread event handling path.

* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.h:
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm:
(WebKit::eventRegionForLayer):
(WebKit::layerEventRegionContainsPoint):
(WebKit::RemoteScrollingTreeMac::eventListenerRegionTypesForPoint const):

Canonical link: https://commits.webkit.org/257531@main

1df06c2

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 ❌ πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  watch-sim

@smfr smfr requested a review from cdumez as a code owner December 7, 2022 01:07
@smfr smfr self-assigned this Dec 7, 2022
@smfr smfr added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Dec 7, 2022
@smfr smfr requested a review from hortont424 December 7, 2022 04:16
@smfr smfr added the merge-queue Applied to send a pull request to merge-queue label Dec 8, 2022
… for JS event handlers

https://bugs.webkit.org/show_bug.cgi?id=248846

Reviewed by Tim Horton.

Override `eventListenerRegionTypesForPoint()` in RemoteScrollingTreeMac just as we do in ScrollingTreeMac
to get the event handler details for a given point. We use this to know if we have to continue with the
web process/main thread event handling path.

* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.h:
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm:
(WebKit::eventRegionForLayer):
(WebKit::layerEventRegionContainsPoint):
(WebKit::RemoteScrollingTreeMac::eventListenerRegionTypesForPoint const):

Canonical link: https://commits.webkit.org/257531@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/UI-side-compositing-Ensure-that-wheel-events-got-to-the-web-process-for-JS-event-handlers branch from 1df06c2 to 066e5bd Compare December 8, 2022 02:12
@webkit-commit-queue
Copy link
Collaborator

Committed 257531@main (066e5bd): https://commits.webkit.org/257531@main

Reviewed commits have been landed. Closing PR #7234 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 066e5bd into WebKit:main Dec 8, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit Process Model Bugs related to WebKit's multi-process architecture
Projects
None yet
4 participants