Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for <model src> and honor <source type> attributes #7245

Merged
merged 1 commit into from Dec 7, 2022
Merged

Add support for <model src> and honor <source type> attributes #7245

merged 1 commit into from Dec 7, 2022

Conversation

heycam
Copy link
Contributor

@heycam heycam commented Dec 7, 2022 •
edited by webkit-early-warning-system

7d493da

Add support for <model src> and honor <source type> attributes
https://bugs.webkit.org/show_bug.cgi?id=248855
rdar://problem/103056552

Reviewed by Antoine Quint.

* LayoutTests/model-element/model-element-source-expected.txt:
* LayoutTests/model-element/model-element-source.html:
* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::isSupportedModelType):
(WebCore::HTMLModelElement::selectModelSource const):
(WebCore::HTMLModelElement::sourcesChanged):
(WebCore::HTMLModelElement::parseAttribute):
(WebCore::HTMLModelElement::isURLAttribute const):
(WebCore::HTMLModelElement::attributeChanged): Deleted.
* Source/WebCore/Modules/model-element/HTMLModelElement.h:
* Source/WebCore/Modules/model-element/HTMLModelElement.idl:

Canonical link: https://commits.webkit.org/257518@main

9ccf064

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ⏳ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ⏳ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 merge ❌ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@heycam heycam self-assigned this Dec 7, 2022
@heycam heycam added the Layout and Rendering For bugs with layout and rendering of Web pages. label Dec 7, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash d1ec75c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ⏳ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac ⏳ 🧪 gtk-wk2
⏳ 🧪 api-ios   🧪 mac-wk1 ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ⏳ 🛠 tv   🧪 mac-wk2 ⏳ 🛠 jsc-armv7
⏳ 🛠 tv-sim ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch   🧪 mac-wk2-stress
⏳ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 9ccf064)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ⏳ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ⏳ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 merge ❌ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 7, 2022
@heycam heycam added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Dec 7, 2022
@heycam
Add support for <model src> and honor <source type> attributes
7d493da 
https://bugs.webkit.org/show_bug.cgi?id=248855
rdar://problem/103056552

Reviewed by Antoine Quint.

* LayoutTests/model-element/model-element-source-expected.txt:
* LayoutTests/model-element/model-element-source.html:
* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::isSupportedModelType):
(WebCore::HTMLModelElement::selectModelSource const):
(WebCore::HTMLModelElement::sourcesChanged):
(WebCore::HTMLModelElement::parseAttribute):
(WebCore::HTMLModelElement::isURLAttribute const):
(WebCore::HTMLModelElement::attributeChanged): Deleted.
* Source/WebCore/Modules/model-element/HTMLModelElement.h:
* Source/WebCore/Modules/model-element/HTMLModelElement.idl:

Canonical link: https://commits.webkit.org/257518@main
@webkit-commit-queue
Copy link
Collaborator

Committed 257518@main (7d493da): https://commits.webkit.org/257518@main

Reviewed commits have been landed. Closing PR #7245 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 7d493da into WebKit:main Dec 7, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graouts graouts graouts approved these changes

@marcoscaceres marcoscaceres Awaiting requested review from marcoscaceres marcoscaceres is a code owner

Assignees

@heycam heycam

Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
Milestone
No milestone
5 participants
@heycam @webkit-early-warning-system @webkit-commit-queue @graouts @webkit-ews-buildbot