WTF::CrashOnOverflow::crash() with /((a{100000000})*b{2100000000})+/.test(); #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaboff
added
JavaScriptCore
achristensen07
approved these changes
May 18, 2022
webkit-early-warning-system
force-pushed
the
eng/WTFCrashOnOverflowcrash-with-a100000000b2100000000-test
branch
from
2ca6b3c
to
7f4a2f1
Compare
|
Committed r294411 (250703@main): https://commits.webkit.org/250703@main Reviewed commits have been landed. Closing PR #733 and removing active labels. |
webkit-early-warning-system
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7f4a2f1
WTF::CrashOnOverflow::crash() with /((a{100000000})*b{2100000000})+/.test(); https://bugs.webkit.org/show_bug.cgi?id=240552 Reviewed by Yusuke Suzuki and Alex Christensen. Replaced a crashing checked add in the YARR JIT code generator with a reporting add so we can catch the overflow. When we do overflow, we terminate the JIT genration with an error. We'll fallback to the YARR interpreter, which already exits with an error on a similar overflow. * JSTests/stress/regexp-large-quantifier.js: (testRegExp): * Source/JavaScriptCore/yarr/YarrJIT.cpp: (JSC::Yarr::dumpCompileFailure): * Source/JavaScriptCore/yarr/YarrJIT.h: Canonical link: https://commits.webkit.org/250703@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294411 268f45cc-cd09-0410-ab3c-d52691b4dbfc