Copy-pasted attachments in mail show up as generic file icons

[kcheney1]

bf65cfe

Copy-pasted attachments in mail show up as generic file icons
https://bugs.webkit.org/show_bug.cgi?id=240586
rdar://91067102

Reviewed by Wenson Hsieh.

Generate QuickLook previews for attachments that are copy-pasted as
webarchives, such as pages, keynote and numbers docs.

* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(testiWorkAttachmentFileURL):
(testiWorkAttachmentData):
(TestWebKitAPI::TEST):
(TestWebKitAPI::_generateBestRepresentationForRequest):
Swizzle QLThumbnailGenerator code to make sure we hit image generation.
This is not an ideal test but ensures we at least hit the right code
path since we are unable to directly compare icons.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/test.pages: Added.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::registerAttachmentsFromSerializedData):

Canonical link: https://commits.webkit.org/250719@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[kcheney1]

oops, will remove this extra space

[whsieh]

It might be a good idea to put this swizzler below the

[webView _synchronouslyExecuteEditCommand:@"Cut" argument:nil];

..line below. If we eventually fix -_insertAttachmentWithFileWrapper: to automatically request QL thumbnails for the inserted attachment, then I think this test might become a false positive (since we'll get two calls to the swizzled _generateBestRepresentationForRequest).

[kcheney1]

Ok - I reset the bool variable to false below to avoid that but probably safe to move the swizzler as well.

Thanks for the review!

[webkit-early-warning-system]

Committed r294451 (250719@main): https://commits.webkit.org/250719@main

Reviewed commits have been landed. Closing PR #735 and removing active labels.