CSS ::marker does not support defining CSS variables

[karlcow]

52052a2

CSS `::marker` does not support defining CSS variables
https://bugs.webkit.org/show_bug.cgi?id=241566
rdar://problem/95551387

Reviewed by Tim Nguyen and Antti Koivisto.

This aligns WebKit with Firefox and Chrome. It adds
CSSPropertyCustom into isValidMarkerStyleProperty
and isValidCueStyleProperty. This also adds two new
Web Platform Tests for css marker.

* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable-computed-style-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable-computed-style.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable.html: Added.
* Source/WebCore/style/PropertyAllowlist.cpp:
(WebCore::Style::isValidMarkerStyleProperty):
(WebCore::Style::isValidCueStyleProperty):

Canonical link: https://commits.webkit.org/257711@main

eab5e35

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	🧪 gtk-wk2
	⏳ 🧪 api-ios	✅ 🧪 mac-wk1	⏳ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 13f620f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
⏳ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

[nt1m]

Please add a reftest (WPT would be the preference).

[anttijk]

A test would be cool.

[karlcow]

Please add a reftest (WPT would be the preference).

@nt1m https://github.com/web-platform-tests/wpt/pull/37427/files
would that work.

I tried an automated test, but I can't extract the color with window.getComputedStyle (maybe anti-fingerprinting?)

[brandonmcconnell]

@karlcow I'm able to extract the colors for ::marker using window.getComputedStyle's second arg. Both should work in Safari as well once the fix has been added. Currently, a color value is extracted in both browsers, but—due to this bug—Safari shows rgb(0, 0, 0) for the second test, which should change once this fix is in place:

• Test Fix typo in domain.endsWith() check for hulu.com #1: https://codepen.io/brandonmcconnell/pen/XWYQXVx/00443c64dda4b652a5aa9e799e68a8bf
• Test Build support for Haiku operating system #2: https://codepen.io/brandonmcconnell/pen/XWYQKYa/bce9808bf5d624fab3a81ee35a778d47

Hope this helps 🙂

for (const li of document.querySelectorAll('li')) {
  const markerStyles = window.getComputedStyle(li, 'marker');
  const markerColor = markerStyles.color; // <-- the extracted color
}

Test	Chrome	Safari
1
2

[karlcow]

@karlcow I'm able to extract the colors for ::marker using window.getComputedStyle's second arg.

doh! I realized my mistake this morning. OK. I have an automated test.
conundrum. Firefox fails the automated test, while still doing the right thing for the color.

[nt1m]

Can you import the 2 tests you've added as part of this patch?

[karlcow]

Can you import the 2 tests you've added as part of this patch?

@nt1m DONE!

[webkit-early-warning-system]

EWS run on current version of this PR (hash eab5e35)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	🧪 gtk-wk2
	⏳ 🧪 api-ios	✅ 🧪 mac-wk1	⏳ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

[webkit-commit-queue]

Committed 257711@main (52052a2): https://commits.webkit.org/257711@main

Reviewed commits have been landed. Closing PR #7376 and removing active labels.