Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable unprefixed version of the fullscreen API #7416

Merged
merged 1 commit into from Dec 10, 2022
Merged

Enable unprefixed version of the fullscreen API #7416

merged 1 commit into from Dec 10, 2022

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Dec 9, 2022 •
edited by webkit-early-warning-system

d4cdd5f

Enable unprefixed version of the fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=246039
rdar://100782797

Reviewed by Chris Dumez.

* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:

Canonical link: https://commits.webkit.org/257658@main

5a84976

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🛠 ios-sim   🛠 mac-AS-debug   🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
loading 🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch   🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@nt1m nt1m self-assigned this Dec 9, 2022
@nt1m nt1m changed the title ??? Enable unprefixed version of the fullscreen API Dec 9, 2022
@nt1m nt1m added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Dec 9, 2022
@nt1m nt1m requested a review from cdumez December 9, 2022 23:29
cdumez
cdumez approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 5a84976)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🛠 ios-sim   🛠 mac-AS-debug   🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
loading 🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch   🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 10, 2022
@nt1m
Enable unprefixed version of the fullscreen API
d4cdd5f 
https://bugs.webkit.org/show_bug.cgi?id=246039
rdar://100782797

Reviewed by Chris Dumez.

* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:

Canonical link: https://commits.webkit.org/257658@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Enable-unprefixed-version-of-the-fullscreen-API branch from 5a84976 to d4cdd5f Compare December 10, 2022 01:45
@webkit-commit-queue
Copy link
Collaborator

Committed 257658@main (d4cdd5f): https://commits.webkit.org/257658@main

Reviewed commits have been landed. Closing PR #7416 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit d4cdd5f into WebKit:main Dec 10, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 10, 2022
@nt1m nt1m deleted the eng/Enable-unprefixed-version-of-the-fullscreen-API branch December 10, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@nt1m nt1m

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
4 participants
@nt1m @webkit-early-warning-system @webkit-commit-queue @cdumez