Web Inspector: Fix use-after-move in Inspector::InspectorDebuggerAgent::didCreateNativeExecutable() #7430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash c887a3c) |
webkit-ews-buildbot
added
the
merging-blocked
patrickangle
approved these changes
Dec 12, 2022
ddkilzer
removed
the
merging-blocked
ddkilzer
force-pushed
the
ddkilzer/use-after-move-in-Inspector-InspectorDebuggerAgent-didCreateNativeExecutable
branch
from
c887a3c
to
4e2a26a
Compare
|
EWS run on current version of this PR (hash 4e2a26a) |
…t::didCreateNativeExecutable() https://bugs.webkit.org/show_bug.cgi?id=249064 <rdar://103204166> Reviewed by Patrick Angle. Fix use-after-move of `oldJITCodeRef` by using moved-to variable in RELEASE_ASSERT() expressions. * Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp: (Inspector::InspectorDebuggerAgent::didCreateNativeExecutable): Canonical link: https://commits.webkit.org/257755@main
webkit-early-warning-system
force-pushed
the
ddkilzer/use-after-move-in-Inspector-InspectorDebuggerAgent-didCreateNativeExecutable
branch
from
4e2a26a
to
9dbd001
Compare
|
Committed 257755@main (9dbd001): https://commits.webkit.org/257755@main Reviewed commits have been landed. Closing PR #7430 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
ddkilzer
deleted the
ddkilzer/use-after-move-in-Inspector-InspectorDebuggerAgent-didCreateNativeExecutable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9dbd001
4e2a26a
🧪 api-mac🧪 gtk-wk2🧪 api-ios