Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling the CSS Motion Path experimental feature does not prevent parsing of CSS Motion Path properties in Safari 15.3 and up #745

Closed
wants to merge 2 commits into from
Closed

Disabling the CSS Motion Path experimental feature does not prevent parsing of CSS Motion Path properties in Safari 15.3 and up #745

wants to merge 2 commits into from

Conversation

graouts
Copy link
Contributor

@graouts graouts commented May 18, 2022 •
edited

bedda8e

Disabling the CSS Motion Path experimental feature does not prevent parsing of CSS Motion Path properties in Safari 15.3 and up
https://bugs.webkit.org/show_bug.cgi?id=240599
<rdar://93518191>

Reviewed by NOBODY (OOPS!).

* Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::operator==):
(WebCore::add):
(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseSingleValue):

@alancoon
Cherry-pick r294012. rdar://problem/92425915
6a5122b 
    Fix inertness of pseudo-elements
    https://bugs.webkit.org/show_bug.cgi?id=239831

    Reviewed by Antti Koivisto.

    When we adjust style for a pseudo-element, `m_element` and `document().activeModalDialog()` are both null. So we accidentally reset inertness to false in those cases.

    Fix this by making checking for m_element's existence too.

    LayoutTests/imported/w3c:

    * web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.
    * web-platform-tests/inert/inert-pseudo-element-hittest.html: Added.

    Source/WebCore:

    Test: imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest.html

    * style/StyleAdjuster.cpp:
    (WebCore::Style::Adjuster::adjust const):

    LayoutTests:

    * platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.

    Canonical link: https://commits.webkit.org/250446@main
    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Canonical link: https://commits.webkit.org/245886.580@safari-613-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-613-branch@294305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
@graouts graouts requested a review from anttijk May 18, 2022 21:20
@graouts graouts force-pushed the disable-motion-path-on-safari-613-branch branch from a3c81f4 to 4059b46 Compare May 18, 2022 21:22
@graouts
Disabling the CSS Motion Path experimental feature does not prevent p…
bedda8e 
…arsing of CSS Motion Path properties in Safari 15.3 and up

https://bugs.webkit.org/show_bug.cgi?id=240599
<rdar://93518191>

Reviewed by NOBODY (OOPS!).

No new tests (OOPS!).
* Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::operator==):
(WebCore::add):
(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseSingleValue):
@graouts graouts force-pushed the disable-motion-path-on-safari-613-branch branch from 4059b46 to bedda8e Compare May 18, 2022 21:24
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 19, 2022
anttijk
anttijk approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@anttijk anttijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge before there is a decision about taking this to the branch.

@aj062
Copy link
Member

aj062 commented May 21, 2022

Cancelled couple of EWS builds for this PR since they were stuck in infinite retry loop.
e.g.: https://ews-build.webkit.org/#/builders/66/builds/17985
https://ews-build.webkit.org/#/builders/64/builds/19189
https://ews-build.webkit.org/#/builders/69/builds/20787
https://ews-build.webkit.org/#/builders/36/builds/67494

cc @JonWBedard

@graouts graouts closed this Jun 24, 2022
@graouts graouts deleted the disable-motion-path-on-safari-613-branch branch June 24, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttijk anttijk anttijk approved these changes

Assignees
No one assigned
Labels
merging-blocked Applied to prevent a change from being merged
Projects
None yet
Milestone
No milestone
5 participants
@graouts @aj062 @anttijk @webkit-early-warning-system @alancoon