Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary nullptr check from GridMasonryLayout::addItemsToFirstTrack. #7455

Merged
merged 1 commit into from Dec 12, 2022
Merged

Remove unnecessary nullptr check from GridMasonryLayout::addItemsToFirstTrack. #7455

merged 1 commit into from Dec 12, 2022

Conversation

sammygill
Copy link
Contributor

@sammygill sammygill commented Dec 11, 2022 •
edited by webkit-early-warning-system

3f50a04

Remove unnecessary nullptr check from GridMasonryLayout::addItemsToFirstTrack.
https://bugs.webkit.org/show_bug.cgi?id=249104
rdar://103230303

Reviewed by Alan Baradlay.

The HashMap implementation would not allow a nullptr to get inserted
into the HashMap when a raw C++ pointer is being used as the key,
so the code that iterates over all of the keys and values should not
need to check for nullptr.

The HashMap implementation would not allow a nullptr to get inserted
into the HashMap when a raw C++ pointer is being used as the key,
so the code that iterates over all of the keys and values should not
need to check for nullptr.

* Source/WebCore/rendering/GridMasonryLayout.cpp:
(WebCore::GridMasonryLayout::addItemsToFirstTrack):

Canonical link: https://commits.webkit.org/257714@main

1f55913

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
⏳ 🧪 api-ios ✅ 🧪 mac-wk1 ⏳ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@sammygill sammygill self-assigned this Dec 11, 2022
@sammygill sammygill added the CSS Cascading Style Sheets implementation label Dec 11, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 3cf3bc9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios   🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim   🛠 mac-AS-debug ✅ 🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
⏳ 🧪 api-ios   🧪 mac-wk1 ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ⏳ 🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
  🛠 watch   🧪 mac-wk2-stress
✅ 🛠 watch-sim

@sammygill sammygill force-pushed the eng/css-grid-GridMasonryLayoutaddItemsToFirstTrack-remove-unnecessary-nullptr-check branch from 3cf3bc9 to 1f55913 Compare December 11, 2022 20:08
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 1f55913)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
⏳ 🧪 api-ios ✅ 🧪 mac-wk1 ⏳ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@sammygill sammygill added the merge-queue Applied to send a pull request to merge-queue label Dec 12, 2022
@sammygill
Remove unnecessary nullptr check from GridMasonryLayout::addItemsToFi…
3f50a04 
…rstTrack.

https://bugs.webkit.org/show_bug.cgi?id=249104
rdar://103230303

Reviewed by Alan Baradlay.

The HashMap implementation would not allow a nullptr to get inserted
into the HashMap when a raw C++ pointer is being used as the key,
so the code that iterates over all of the keys and values should not
need to check for nullptr.

The HashMap implementation would not allow a nullptr to get inserted
into the HashMap when a raw C++ pointer is being used as the key,
so the code that iterates over all of the keys and values should not
need to check for nullptr.

* Source/WebCore/rendering/GridMasonryLayout.cpp:
(WebCore::GridMasonryLayout::addItemsToFirstTrack):

Canonical link: https://commits.webkit.org/257714@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/css-grid-GridMasonryLayoutaddItemsToFirstTrack-remove-unnecessary-nullptr-check branch from 1f55913 to 3f50a04 Compare December 12, 2022 05:11
@webkit-commit-queue
Copy link
Collaborator

Committed 257714@main (3f50a04): https://commits.webkit.org/257714@main

Reviewed commits have been landed. Closing PR #7455 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 3f50a04 into WebKit:main Dec 12, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 12, 2022
@sammygill sammygill deleted the eng/css-grid-GridMasonryLayoutaddItemsToFirstTrack-remove-unnecessary-nullptr-check branch April 19, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanbaradlay alanbaradlay alanbaradlay approved these changes

Assignees

@sammygill sammygill

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
4 participants
@sammygill @webkit-early-warning-system @webkit-commit-queue @alanbaradlay