Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-land Masonry cleanup #7496

Merged
merged 1 commit into from Dec 13, 2022
Merged

Re-land Masonry cleanup #7496

merged 1 commit into from Dec 13, 2022

Conversation

stwrt
Copy link
Member

@stwrt stwrt commented Dec 12, 2022 •
edited by webkit-early-warning-system

9420329

Re-land Masonry cleanup
https://bugs.webkit.org/show_bug.cgi?id=249156

Reviewed by Brent Fulgham.

This was supposed to be a simple cleanup patch. Ran into some issues with unexpected global state
changes wrecking havoc on my last patch causing several masonry tests to fail.
Let's try to reland this again.

Canonical link: https://commits.webkit.org/257799@main

e16527a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ⏳ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@stwrt stwrt self-assigned this Dec 12, 2022
@stwrt stwrt added the CSS Cascading Style Sheets implementation label Dec 12, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash e16527a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ⏳ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

brentfulgham
brentfulgham approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable. r=me if the bots are happy.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 13, 2022
@stwrt stwrt added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Dec 13, 2022
@stwrt
Re-land Masonry cleanup
9420329 
https://bugs.webkit.org/show_bug.cgi?id=249156

Reviewed by Brent Fulgham.

This was supposed to be a simple cleanup patch. Ran into some issues with unexpected global state
changes wrecking havoc on my last patch causing several masonry tests to fail.
Let's try to reland this again.

Canonical link: https://commits.webkit.org/257799@main
@webkit-commit-queue
Copy link
Collaborator

Committed 257799@main (9420329): https://commits.webkit.org/257799@main

Reviewed commits have been landed. Closing PR #7496 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 13, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 9420329 into WebKit:main Dec 13, 2022
@stwrt stwrt deleted the eng/small_masonry_retry branch December 13, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@sammygill sammygill Awaiting requested review from sammygill

Assignees

@stwrt stwrt

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
5 participants
@stwrt @webkit-early-warning-system @webkit-commit-queue @brentfulgham @webkit-ews-buildbot