Add inspectable property to _WKWebExtensionContext. #7497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash 8befe62)
|
🧪 api-mac
b-weinstein
approved these changes
Dec 12, 2022
xeenon
added
the
unsafe-merge-queue
patrickangle
approved these changes
Dec 12, 2022
| @discussion A context can control multiple `WKWebView` instances, from the background content, to the popover. | ||
| You should set this to `YES` when needed for debugging purposes. The default value is `NO`. | ||
| */ | ||
| @property (nonatomic, getter=isInspectable) BOOL inspectable; |
There was a problem hiding this comment.
Will this property expose itself in Swift as isInspectable, or do we need to add NS_SWIFT_NAME(isInspectable) to match the inspectable property from JSContext and WKWebView? (During API review we had determined the inspectable was the correct property name for ObjC, and isInspectable was the correct property name for Swift).
https://bugs.webkit.org/show_bug.cgi?id=249158 Reviewed by Brian Weinstein. Also fix some typos in other HeadDoc comments. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm: (-[_WKWebExtensionContext isInspectable]): Added. (-[_WKWebExtensionContext setInspectable:]): Added. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::setInspectable): Added. (WebKit::WebExtensionContext::loadBackgroundWebView): Set inspectable proeprty. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: (WebKit::WebExtensionContext::isInspectable const): Added. Canonical link: https://commits.webkit.org/257740@main
webkit-early-warning-system
force-pushed
the
bug/249158
branch
from
8befe62
to
aeaa834
Compare
|
Committed 257740@main (aeaa834): https://commits.webkit.org/257740@main Reviewed commits have been landed. Closing PR #7497 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aeaa834
8befe62
🛠 mac-AS-debug🛠 gtk🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 tv🧪 mac-wk2🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress🛠 watch-sim