Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable IndexedDB in Lockdown Mode #7506

Conversation

brentfulgham
Copy link
Contributor

@brentfulgham brentfulgham commented Dec 12, 2022

Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 13, 2022
@brentfulgham
Copy link
Contributor Author

The "media/video-timeupdate-during-playback.html" does not fail on a local Mac WK2 build, and review of the test case and support libraries show that it does not used IndexedDB.

@brentfulgham brentfulgham removed the merging-blocked Applied to prevent a change from being merged label Dec 13, 2022
@brentfulgham brentfulgham force-pushed the eng/Disable-IndexedDB-in-Lockdown-Mode branch from 5cee726 to 1dc3a97 Compare December 13, 2022 17:56
@brentfulgham brentfulgham self-assigned this Dec 13, 2022
@brentfulgham brentfulgham added WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). merge-queue Applied to send a pull request to merge-queue labels Dec 13, 2022
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Disable-IndexedDB-in-Lockdown-Mode branch from 1dc3a97 to 0c859f1 Compare December 13, 2022 19:17
https://bugs.webkit.org/show_bug.cgi?id=249176
<rdar://101187278>

Reviewed by Chris Dumez.

Add 'IndexedDB' to the set of Web API's disabled in Lockdown Mode.

* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::adjustSettingsForLockdownMode):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Canonical link: https://commits.webkit.org/257804@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Disable-IndexedDB-in-Lockdown-Mode branch from 0c859f1 to 219be21 Compare December 13, 2022 19:20
@webkit-commit-queue
Copy link
Collaborator

Committed 257804@main (219be21): https://commits.webkit.org/257804@main

Reviewed commits have been landed. Closing PR #7506 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 219be21 into WebKit:main Dec 13, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
5 participants