Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lockdown Mode] Disable CacheStorage API #7578

Merged
merged 1 commit into from Dec 14, 2022
Merged

[Lockdown Mode] Disable CacheStorage API #7578

merged 1 commit into from Dec 14, 2022

Conversation

brentfulgham
Copy link
Contributor

@brentfulgham brentfulgham commented Dec 14, 2022 •
edited by webkit-early-warning-system

e482283

[Lockdown Mode] Disable CacheStorage API
https://bugs.webkit.org/show_bug.cgi?id=249268
<rdar://103316598>

Reviewed by Chris Dumez.

Disable the CacheStorage API in Lockdown Mode.

* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::adjustSettingsForLockdownMode):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Canonical link: https://commits.webkit.org/257864@main

c363bc6

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1 ⏳ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@brentfulgham brentfulgham self-assigned this Dec 14, 2022
@brentfulgham brentfulgham added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Dec 14, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash c363bc6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1 ⏳ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

cdumez
cdumez approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brentfulgham brentfulgham added the merge-queue Applied to send a pull request to merge-queue label Dec 14, 2022
[Lockdown Mode] Disable CacheStorage API
e482283 
https://bugs.webkit.org/show_bug.cgi?id=249268
<rdar://103316598>

Reviewed by Chris Dumez.

Disable the CacheStorage API in Lockdown Mode.

* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::adjustSettingsForLockdownMode):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Canonical link: https://commits.webkit.org/257864@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Lockdown-Mode-Disable-CacheStorage-API branch from c363bc6 to e482283 Compare December 14, 2022 17:30
@webkit-commit-queue
Copy link
Collaborator

Committed 257864@main (e482283): https://commits.webkit.org/257864@main

Reviewed commits have been landed. Closing PR #7578 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e482283 into WebKit:main Dec 14, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@brentfulgham brentfulgham

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@brentfulgham @webkit-early-warning-system @webkit-commit-queue @cdumez