Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete WKHoverPlatter #763

Merged
merged 0 commits into from
May 19, 2022
Merged

Delete WKHoverPlatter #763

merged 0 commits into from
May 19, 2022

Conversation

hortont424
Copy link
Contributor

@hortont424 hortont424 commented May 19, 2022 •
edited by webkit-early-warning-system

fd3414a

Delete WKHoverPlatter
https://bugs.webkit.org/show_bug.cgi?id=240623

Reviewed by Wenson Hsieh.

* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _allowsDoubleTapGestures]):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _createAndConfigureHighlightLongPressGestureRecognizer]):
(-[WKContentView setUpInteraction]):
(-[WKContentView cleanUpInteraction]):
(-[WKContentView _locationForGesture:]):
(-[WKContentView _startPointForGesture:]):
(-[WKContentView _longPressRecognized:]):
(-[WKContentView _singleTapIdentified:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _doubleTapRecognized:]):
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView _shouldUseContextMenus]):
(-[WKContentView setUpDragAndDropInteractions]):
(-[WKContentView mouseGestureRecognizerChanged:]):
(-[WKContentView positionInformationForHoverPlatter:withRequest:completionHandler:]): Deleted.
(-[WKContentView interactionRegionsForHoverPlatter:inRect:completionHandler:]): Deleted.
* Source/WebKit/UIProcess/ios/WKHoverPlatter.h: Removed.
* Source/WebKit/UIProcess/ios/WKHoverPlatter.mm: Removed.
* Source/WebKit/UIProcess/ios/WKHoverPlatterParameters.h: Removed.
* Source/WebKit/UIProcess/ios/WKHoverPlatterParameters.mm: Removed.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/250754@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@hortont424 hortont424 self-assigned this May 19, 2022
@hortont424 hortont424 added WebKit Nightly Build WebKit2 Bugs relating to the WebKit2 API layer labels May 19, 2022
whsieh
whsieh approved these changes May 19, 2022
View reviewed changes
Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Outdated
#endif

return location;
return [gestureRecognizer locationInView:self];
Copy link
Member

@whsieh whsieh May 19, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit - would it be simpler to revert to using [gestureRecognizer locationInView:self];?

(Edit: at each of the individual call sites, I meant to write).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fair point! I will do that. (On the other hand, it is a handy override point. But not one we often need.)

Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Outdated
#endif

return location;
return [gestureRecognizer startPoint];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, w.r.t. just calling -startPoint.

@hortont424 hortont424 added the merge-queue Applied to send a pull request to merge-queue label May 19, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit fd3414a into WebKit:main May 19, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294495 (250754@main): https://commits.webkit.org/250754@main

Reviewed commits have been landed. Closing PR #763 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 19, 2022
@hortont424 hortont424 deleted the eng/Delete-WKHoverPlatter branch June 6, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whsieh whsieh whsieh approved these changes

@grorg grorg Awaiting requested review from grorg

@megangardner megangardner Awaiting requested review from megangardner

Assignees

@hortont424 hortont424

Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
Milestone
No milestone
3 participants
@hortont424 @webkit-early-warning-system @whsieh