[WebGPU] Implement RenderBundleEncoder which appears to be MTLIndirectCommandBuffer #7652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 5654aea)
|
webkit-ews-buildbot
added
the
merging-blocked
grorg
reviewed
Dec 20, 2022
| #import <wtf/FastMalloc.h> | ||
| #import <wtf/Function.h> |
grorg
approved these changes
Dec 20, 2022
mwyrzykowski
removed
the
merging-blocked
mwyrzykowski
force-pushed
the
eng/WebGPU-Implement-RenderBundleEncoder-which-appears-to-be-MTLIndirectCommandBuffer
branch
from
5654aea
to
1d756e7
Compare
|
EWS run on current version of this PR (hash 1d756e7)
|
…tCommandBuffer https://bugs.webkit.org/show_bug.cgi?id=249257 <radar://103318351> Reviewed by Dean Jackson. Creation of the MTLIndirectCommandBuffer is deferred as we need to tell Metal the maximum number of vertex and fragment buffers prior to creating the ICB, along with the number of draw commands. * Source/WebGPU/WebGPU.xcodeproj/project.pbxproj: * Source/WebGPU/WebGPU/BindGroup.h: (WebGPU::BindGroup::create): (WebGPU::BindGroup::resources const): * Source/WebGPU/WebGPU/BindGroup.mm: (WebGPU::Device::createBindGroup): (WebGPU::BindGroup::BindGroup): Renamed struct moved to its own header. * Source/WebGPU/WebGPU/BindableResource.h: Copied from Source/WebGPU/WebGPU/RenderBundle.mm. Moved from BindGroup.h * Source/WebGPU/WebGPU/RenderBundle.h: (WebGPU::RenderBundle::create): (WebGPU::RenderBundle::resources const): * Source/WebGPU/WebGPU/RenderBundle.mm: (WebGPU::RenderBundle::RenderBundle): Cache the ICB and required resources. * Source/WebGPU/WebGPU/RenderBundleEncoder.h: (WebGPU::RenderBundleEncoder::create): * Source/WebGPU/WebGPU/RenderBundleEncoder.mm: (WebGPU::Device::createRenderBundleEncoder): (WebGPU::RenderBundleEncoder::RenderBundleEncoder): (WebGPU::RenderBundleEncoder::currentRenderCommand): (WebGPU::RenderBundleEncoder::draw): (WebGPU::RenderBundleEncoder::drawIndexed): (WebGPU::RenderBundleEncoder::drawIndexedIndirect): (WebGPU::RenderBundleEncoder::drawIndirect): (WebGPU::RenderBundleEncoder::finish): (WebGPU::RenderBundleEncoder::setBindGroup): (WebGPU::RenderBundleEncoder::setIndexBuffer): (WebGPU::RenderBundleEncoder::setPipeline): (WebGPU::RenderBundleEncoder::setVertexBuffer): Implement pipeline functions. * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::executeBundles): * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::Device::createRenderPipeline): * Websites/webkit.org/demos/webgpu/indirect-command-buffer-textured-cube.html: Added. * Websites/webkit.org/demos/webgpu/scripts/indirect-command-buffer-textured-cube.js: Added. (async helloCube.frameUpdate): (async helloCube): Add ICB demo test. * Websites/webkit.org/demos/webgpu/scripts/hello-triangle-msaa.js: (async helloTriangle): * Websites/webkit.org/demos/webgpu/scripts/instanced-textured-cube.js: Miscellaneous test fixes observed running under the debug metal device. Canonical link: https://commits.webkit.org/258226@main
webkit-commit-queue
force-pushed
the
eng/WebGPU-Implement-RenderBundleEncoder-which-appears-to-be-MTLIndirectCommandBuffer
branch
from
1d756e7
to
2022497
Compare
|
Committed 258226@main (2022497): https://commits.webkit.org/258226@main Reviewed commits have been landed. Closing PR #7652 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2022497
1d756e7
🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 api-gtk🧪 mac-AS-debug-wk2🛠 watch