Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for _WKWebExtensionWebNavigationURLFilter. #7665

Conversation

b-weinstein
Copy link
Contributor

@b-weinstein b-weinstein commented Dec 15, 2022

2f58e32

Add tests for _WKWebExtensionWebNavigationURLFilter.
https://bugs.webkit.org/show_bug.cgi?id=249365
rdar://102820594

Reviewed by Timothy Hatcher.

* Source/WebKit/Shared/Extensions/_WKWebExtensionUtilities.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebNavigationURLFilter.h:
* Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebNavigationURLFilter.mm:
(-[_WKWebExtensionWebNavigationURLFilter initWithDictionary:outErrorMessage:]):
(-[_WKWebExtensionWebNavigationURLFilter matchesURL:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebNavigation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/257950@main

f926894

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style   πŸ›  ios   πŸ›  mac   πŸ›  wpe   πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings   πŸ›  ios-sim   πŸ›  mac-AS-debug   πŸ›  gtk   πŸ›  wincairo
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2   πŸ§ͺ api-mac   πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios   πŸ§ͺ mac-wk1   πŸ§ͺ api-gtk
  πŸ›  tv   πŸ§ͺ mac-wk2
  πŸ›  tv-sim   πŸ§ͺ mac-AS-debug-wk2
  πŸ›  watch   πŸ§ͺ mac-wk2-stress
❌ πŸ›  πŸ§ͺ merge   πŸ›  watch-sim

@b-weinstein b-weinstein self-assigned this Dec 15, 2022
@b-weinstein b-weinstein added the WebKit Extensions Bugs related to extension support. label Dec 15, 2022
@b-weinstein b-weinstein force-pushed the eng/Add-tests-for-_WKWebExtensionWebNavigationURLFilter branch from bdc8e33 to 8d1d25c Compare December 15, 2022 05:06
@b-weinstein b-weinstein added the merge-queue Applied to send a pull request to merge-queue label Dec 15, 2022
@b-weinstein b-weinstein removed the merge-queue Applied to send a pull request to merge-queue label Dec 15, 2022
@b-weinstein b-weinstein force-pushed the eng/Add-tests-for-_WKWebExtensionWebNavigationURLFilter branch from 8d1d25c to f926894 Compare December 15, 2022 18:41
@b-weinstein b-weinstein added the merge-queue Applied to send a pull request to merge-queue label Dec 15, 2022
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-tests-for-_WKWebExtensionWebNavigationURLFilter branch 2 times, most recently from 31d79de to 7e4cd54 Compare December 15, 2022 19:57
https://bugs.webkit.org/show_bug.cgi?id=249365
rdar://102820594

Reviewed by Timothy Hatcher.

* Source/WebKit/Shared/Extensions/_WKWebExtensionUtilities.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebNavigationURLFilter.h:
* Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebNavigationURLFilter.mm:
(-[_WKWebExtensionWebNavigationURLFilter initWithDictionary:outErrorMessage:]):
(-[_WKWebExtensionWebNavigationURLFilter matchesURL:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebNavigation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/257950@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-tests-for-_WKWebExtensionWebNavigationURLFilter branch from 7e4cd54 to 2f58e32 Compare December 15, 2022 20:00
@webkit-commit-queue webkit-commit-queue merged commit 2f58e32 into WebKit:main Dec 15, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 257950@main (2f58e32): https://commits.webkit.org/257950@main

Reviewed commits have been landed. Closing PR #7665 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit Extensions Bugs related to extension support.
Projects
None yet
4 participants