[web-animations] custom properties should support interpolation with a single keyframe #7679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graouts
added
the
Animations
|
EWS run on previous version of this PR (hash 1705f1a)
|
graouts
force-pushed
the
custom-property-interpolation-step-3
branch
from
1705f1a
to
ea9ab02
Compare
|
EWS run on current version of this PR (hash ea9ab02)
|
anttijk
approved these changes
Dec 15, 2022
graouts
added
the
unsafe-merge-queue
…a single keyframe https://bugs.webkit.org/show_bug.cgi?id=249384 Reviewed by Antti Koivisto. Custom properties can specify an initial value when registered. However, that value is not available in RenderStyle if the custom property is not provided with an explicit value. This means that when we added basic support for interpolating custom properties in bug 249312, we would fail to gather the right values for interpolating as we'd have a null value if the keyframes did not set explicit values. We can get to the initial value of a custom property through the custom property registry held by the document. So we add a new document() method to CSSPropertyBlendingClient such that we may be able to read from this registry when interpolating from within CSSPropertyAnimation. Then we add a static method customPropertyValuesForBlending that returns a pair of CSSCustomPropertyValue pointers containing either the explicit value set for a custom property, or its initial value. Now we are guaranteed to get the correct values when interpolating. * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-animation-length-expected.txt: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::blendCustomProperty): * Source/WebCore/animation/CSSPropertyBlendingClient.h: * Source/WebCore/animation/KeyframeEffect.h: Canonical link: https://commits.webkit.org/257911@main
webkit-early-warning-system
force-pushed
the
custom-property-interpolation-step-3
branch
from
ea9ab02
to
c3591d2
Compare
|
Committed 257911@main (c3591d2): https://commits.webkit.org/257911@main Reviewed commits have been landed. Closing PR #7679 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c3591d2
ea9ab02
🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 mac-wk2🧪 mac-wk2-stress