Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure CA adjusts video color space consistently when drawing videos to a canvas #7731

Merged
merged 1 commit into from Dec 17, 2022
Merged

Ensure CA adjusts video color space consistently when drawing videos to a canvas #7731

merged 1 commit into from Dec 17, 2022

Conversation

heycam
Copy link
Contributor

@heycam heycam commented Dec 16, 2022 •
edited by webkit-early-warning-system

07a9869

Ensure CA adjusts video color space consistently when drawing videos to a canvas
https://bugs.webkit.org/show_bug.cgi?id=249446
rdar://88804270

Reviewed by Simon Fraser.

* Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:
* Source/WebCore/platform/graphics/cv/PixelBufferConformerCV.cpp:
(WebCore::PixelBufferConformerCV::imageFrom32BGRAPixelBuffer):

Canonical link: https://commits.webkit.org/258030@main

1fcf5ed

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
  🛠 🧪 merge ✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@heycam heycam self-assigned this Dec 16, 2022
@heycam heycam added the Layout and Rendering For bugs with layout and rendering of Web pages. label Dec 16, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 6e48463)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ❌ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac   🧪 gtk-wk2
❌ 🧪 api-ios ❌ 🧪 mac-wk1   🧪 api-gtk
❌ 🛠 tv ❌ 🧪 mac-wk2
❌ 🛠 tv-sim ⏳ 🧪 mac-AS-debug-wk2
❌ 🛠 watch ❌ 🧪 mac-wk2-stress
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 16, 2022
@heycam heycam removed the merging-blocked Applied to prevent a change from being merged label Dec 16, 2022
@heycam heycam force-pushed the video-color-space-adjustment-ca branch from 6e48463 to 1fcf5ed Compare December 16, 2022 07:39
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 1fcf5ed)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
  🛠 🧪 merge ✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@heycam heycam marked this pull request as ready for review December 17, 2022 01:51
@heycam heycam added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels Dec 17, 2022
@heycam
Ensure CA adjusts video color space consistently when drawing videos …
07a9869 
…to a canvas

https://bugs.webkit.org/show_bug.cgi?id=249446
rdar://88804270

Reviewed by Simon Fraser.

* Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:
* Source/WebCore/platform/graphics/cv/PixelBufferConformerCV.cpp:
(WebCore::PixelBufferConformerCV::imageFrom32BGRAPixelBuffer):

Canonical link: https://commits.webkit.org/258030@main
@webkit-commit-queue
Copy link
Collaborator

Committed 258030@main (07a9869): https://commits.webkit.org/258030@main

Reviewed commits have been landed. Closing PR #7731 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 07a9869 into WebKit:main Dec 17, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr smfr approved these changes

Assignees

@heycam heycam

Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
Milestone
No milestone
5 participants
@heycam @webkit-early-warning-system @webkit-commit-queue @smfr @webkit-ews-buildbot