Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[:has() pseudo-class] Support invalidation for :playing, :paused, :seeking, :muted and :volume-locked pseudo-classes #7738

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Dec 16, 2022

703f285

[:has() pseudo-class] Support invalidation for :playing, :paused, :seeking, :muted and :volume-locked pseudo-classes
https://bugs.webkit.org/show_bug.cgi?id=238994
rdar://91802717

Reviewed by Antti Koivisto.

* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/selectors/invalidation/media-pseudo-classes-in-has-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/media-pseudo-classes-in-has-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/media-pseudo-classes-in-has.html: Added.
* LayoutTests/media/media-css-volume-locked-expected.txt:
* LayoutTests/media/media-css-volume-locked.html:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::seekWithTolerance):
(WebCore::HTMLMediaElement::seekTask):
(WebCore::HTMLMediaElement::clearSeeking):
(WebCore::HTMLMediaElement::setSeeking):
(WebCore::HTMLMediaElement::setPaused):
(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::setVolumeLocked):
* Source/WebCore/html/HTMLMediaElement.h:

Canonical link: https://commits.webkit.org/257991@main

c7fb0cc

Misc iOS, tvOS & watchOS macOS Linux Windows
  πŸ§ͺ style   πŸ›  ios   πŸ›  mac   πŸ›  wpe   πŸ›  πŸ§ͺ win
  πŸ§ͺ bindings   πŸ›  ios-sim   πŸ›  mac-AS-debug   πŸ›  gtk   πŸ›  wincairo
  πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2   πŸ§ͺ api-mac   πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios   πŸ§ͺ mac-wk1   πŸ§ͺ api-gtk
  πŸ›  tv   πŸ§ͺ mac-wk2
  πŸ›  tv-sim   πŸ§ͺ mac-AS-debug-wk2
  πŸ›  watch   πŸ§ͺ mac-wk2-stress
  πŸ›  watch-sim
βœ… πŸ›  πŸ§ͺ unsafe-merge

@nt1m nt1m self-assigned this Dec 16, 2022
@nt1m nt1m changed the title ??? [:has() pseudo-class] Support invalidation for :playing, :paused, :seeking, :muted and :volume-locked pseudo-classes Dec 16, 2022
@nt1m nt1m added the CSS Cascading Style Sheets implementation label Dec 16, 2022
@nt1m nt1m requested review from smfr, anttijk and heycam December 16, 2022 08:24
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 16, 2022
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Dec 16, 2022
@nt1m nt1m force-pushed the eng/has-pseudo-class-Support-invalidation-for-playing-paused-seeking-muted-and-volume-locked-pseudo-classes branch from f8274d5 to 705d961 Compare December 16, 2022 16:20
@nt1m nt1m added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Dec 16, 2022
@nt1m nt1m force-pushed the eng/has-pseudo-class-Support-invalidation-for-playing-paused-seeking-muted-and-volume-locked-pseudo-classes branch from 705d961 to c7fb0cc Compare December 16, 2022 16:24
@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 16, 2022
…eking, :muted and :volume-locked pseudo-classes

https://bugs.webkit.org/show_bug.cgi?id=238994
rdar://91802717

Reviewed by Antti Koivisto.

* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/selectors/invalidation/media-pseudo-classes-in-has-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/media-pseudo-classes-in-has-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/media-pseudo-classes-in-has.html: Added.
* LayoutTests/media/media-css-volume-locked-expected.txt:
* LayoutTests/media/media-css-volume-locked.html:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::seekWithTolerance):
(WebCore::HTMLMediaElement::seekTask):
(WebCore::HTMLMediaElement::clearSeeking):
(WebCore::HTMLMediaElement::setSeeking):
(WebCore::HTMLMediaElement::setPaused):
(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::setVolumeLocked):
* Source/WebCore/html/HTMLMediaElement.h:

Canonical link: https://commits.webkit.org/257991@main
@webkit-early-warning-system
Copy link
Collaborator

Starting EWS tests for 705d961. Live statuses available at the PR page, #7738

@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/has-pseudo-class-Support-invalidation-for-playing-paused-seeking-muted-and-volume-locked-pseudo-classes branch from c7fb0cc to 703f285 Compare December 16, 2022 16:27
@webkit-commit-queue
Copy link
Collaborator

Committed 257991@main (703f285): https://commits.webkit.org/257991@main

Reviewed commits have been landed. Closing PR #7738 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 703f285 into WebKit:main Dec 16, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 16, 2022
@nt1m nt1m deleted the eng/has-pseudo-class-Support-invalidation-for-playing-paused-seeking-muted-and-volume-locked-pseudo-classes branch December 16, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
5 participants