New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[:has() pseudo-class] Support invalidation for :playing, :paused, :seeking, :muted and :volume-locked pseudo-classes #7738
Merged
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
nt1m:eng/has-pseudo-class-Support-invalidation-for-playing-paused-seeking-muted-and-volume-locked-pseudo-classes
Dec 16, 2022
Merged
[:has() pseudo-class] Support invalidation for :playing, :paused, :seeking, :muted and :volume-locked pseudo-classes #7738
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
nt1m:eng/has-pseudo-class-Support-invalidation-for-playing-paused-seeking-muted-and-volume-locked-pseudo-classes
Dec 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt1m
changed the title
???
[:has() pseudo-class] Support invalidation for :playing, :paused, :seeking, :muted and :volume-locked pseudo-classes
Dec 16, 2022
EWS run on previous version of this PR (hash f8274d5) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Dec 16, 2022
anttijk
approved these changes
Dec 16, 2022
nt1m
force-pushed
the
eng/has-pseudo-class-Support-invalidation-for-playing-paused-seeking-muted-and-volume-locked-pseudo-classes
branch
from
December 16, 2022 16:20
f8274d5
to
705d961
Compare
nt1m
added
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
and removed
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
labels
Dec 16, 2022
nt1m
force-pushed
the
eng/has-pseudo-class-Support-invalidation-for-playing-paused-seeking-muted-and-volume-locked-pseudo-classes
branch
from
December 16, 2022 16:24
705d961
to
c7fb0cc
Compare
nt1m
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Dec 16, 2022
β¦eking, :muted and :volume-locked pseudo-classes https://bugs.webkit.org/show_bug.cgi?id=238994 rdar://91802717 Reviewed by Antti Koivisto. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/selectors/invalidation/media-pseudo-classes-in-has-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/media-pseudo-classes-in-has-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/media-pseudo-classes-in-has.html: Added. * LayoutTests/media/media-css-volume-locked-expected.txt: * LayoutTests/media/media-css-volume-locked.html: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::seekWithTolerance): (WebCore::HTMLMediaElement::seekTask): (WebCore::HTMLMediaElement::clearSeeking): (WebCore::HTMLMediaElement::setSeeking): (WebCore::HTMLMediaElement::setPaused): (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::setVolumeLocked): * Source/WebCore/html/HTMLMediaElement.h: Canonical link: https://commits.webkit.org/257991@main
EWS run on previous version of this PR (hash 705d961) |
EWS run on current version of this PR (hash c7fb0cc) |
webkit-early-warning-system
force-pushed
the
eng/has-pseudo-class-Support-invalidation-for-playing-paused-seeking-muted-and-volume-locked-pseudo-classes
branch
from
December 16, 2022 16:27
c7fb0cc
to
703f285
Compare
Committed 257991@main (703f285): https://commits.webkit.org/257991@main Reviewed commits have been landed. Closing PR #7738 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Dec 16, 2022
nt1m
deleted the
eng/has-pseudo-class-Support-invalidation-for-playing-paused-seeking-muted-and-volume-locked-pseudo-classes
branch
December 16, 2022 16:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
703f285
c7fb0cc
π§ͺ styleπ iosπ macπ wpeπ π§ͺ winπ§ͺ bindingsπ ios-simπ mac-AS-debugπ gtkπ wincairoπ§ͺ webkitperlπ§ͺ ios-wk2π§ͺ api-macπ§ͺ gtk-wk2π§ͺ api-iosπ§ͺ mac-wk1π§ͺ api-gtkπ tvπ§ͺ mac-wk2π tv-simπ§ͺ mac-AS-debug-wk2π watchπ§ͺ mac-wk2-stressπ watch-sim