Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The MacCatalyst build shouldn't install a redundant copy of webpushtool #7866

Merged
merged 1 commit into from Dec 19, 2022
Merged

The MacCatalyst build shouldn't install a redundant copy of webpushtool #7866

merged 1 commit into from Dec 19, 2022

Conversation

whsieh
Copy link
Member

@whsieh whsieh commented Dec 19, 2022 •
edited by webkit-early-warning-system

311b537

The MacCatalyst build shouldn't install a redundant copy of `webpushtool`
https://bugs.webkit.org/show_bug.cgi?id=249606

Reviewed by Brady Eidson.

Avoid installing a second copy of `webpushtool` when building WebKit for Catalyst, by skipping
installation for `webpushtool` (the original copy is already installed when building for macOS
proper).

* Source/WebKit/Configurations/webpushtool.xcconfig:

Canonical link: https://commits.webkit.org/258091@main

606ac30

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac   🛠 wpe
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
  🛠 tv   🧪 mac-wk2
  🛠 tv-sim   🧪 mac-AS-debug-wk2
  🛠 watch   🧪 mac-wk2-stress
  🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@whsieh whsieh self-assigned this Dec 19, 2022
@whsieh whsieh added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Dec 19, 2022
@whsieh whsieh requested a review from beidson December 19, 2022 21:37
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 606ac30)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac   🛠 wpe
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
  🛠 tv   🧪 mac-wk2
  🛠 tv-sim   🧪 mac-AS-debug-wk2
  🛠 watch   🧪 mac-wk2-stress
  🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

beidson
beidson approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@beidson beidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whsieh whsieh added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 19, 2022
@whsieh
The MacCatalyst build shouldn't install a redundant copy of `webpusht…
311b537 
…ool`

https://bugs.webkit.org/show_bug.cgi?id=249606

Reviewed by Brady Eidson.

Avoid installing a second copy of `webpushtool` when building WebKit for Catalyst, by skipping
installation for `webpushtool` (the original copy is already installed when building for macOS
proper).

* Source/WebKit/Configurations/webpushtool.xcconfig:

Canonical link: https://commits.webkit.org/258091@main
@webkit-commit-queue
Copy link
Collaborator

Committed 258091@main (311b537): https://commits.webkit.org/258091@main

Reviewed commits have been landed. Closing PR #7866 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 311b537 into WebKit:main Dec 19, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beidson beidson beidson approved these changes

Assignees

@whsieh whsieh

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@whsieh @webkit-early-warning-system @webkit-commit-queue @beidson