Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ews-build.webkit.org] Handle missing commit record #7890

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Dec 20, 2022

fc82999

[ews-build.webkit.org] Handle missing commit record
https://bugs.webkit.org/show_bug.cgi?id=249625
rdar://103538068

Reviewed by Ryan Haddad.

Not all commits EWS tests have been reported to results.webkit.org. This
may be because merge-queue is ahead of post-commit infrastructure, or because
we collapse build requests on build.webkit.org. We can easily detect this case,
though, an use tip-of-tree as our baseline instead.

* Tools/CISupport/ews-build/results_db.py:
(ResultsDatabase.is_test_expected_to):
(ResultsDatabase.has_commit): Return True if the commit record exists, false if it does not.
* Tools/CISupport/ews-build/steps.py:
(RunWebKitTests.filter_failures_using_results_db):

Canonical link: https://commits.webkit.org/258167@main

2935d3f

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 ❌ πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ§ͺ services βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  watch-sim
βœ… πŸ›  πŸ§ͺ unsafe-merge

@JonWBedard JonWBedard self-assigned this Dec 20, 2022
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Dec 20, 2022
@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 20, 2022
https://bugs.webkit.org/show_bug.cgi?id=249625
rdar://103538068

Reviewed by Ryan Haddad.

Not all commits EWS tests have been reported to results.webkit.org. This
may be because merge-queue is ahead of post-commit infrastructure, or because
we collapse build requests on build.webkit.org. We can easily detect this case,
though, an use tip-of-tree as our baseline instead.

* Tools/CISupport/ews-build/results_db.py:
(ResultsDatabase.is_test_expected_to):
(ResultsDatabase.has_commit): Return True if the commit record exists, false if it does not.
* Tools/CISupport/ews-build/steps.py:
(RunWebKitTests.filter_failures_using_results_db):

Canonical link: https://commits.webkit.org/258167@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/ews-build-webkit-org-Handle-missing-commit-record branch from 2935d3f to fc82999 Compare December 20, 2022 23:27
@webkit-early-warning-system webkit-early-warning-system merged commit fc82999 into WebKit:main Dec 20, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 258167@main (fc82999): https://commits.webkit.org/258167@main

Reviewed commits have been landed. Closing PR #7890 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 20, 2022
@JonWBedard JonWBedard deleted the eng/ews-build-webkit-org-Handle-missing-commit-record branch December 21, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants