[run-webkit-tests] Strip allows*HTTPS* logging messages #7917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
added
the
Tools / Tests
|
EWS run on previous version of this PR (hash a6c7e66)
|
JonWBedard
force-pushed
the
eng/run-webkit-tests-Strip-allowsHTTPS-logging-messages
branch
from
a6c7e66
to
ae959cb
Compare
|
EWS run on previous version of this PR (hash ae959cb)
|
aproskuryakov
approved these changes
Dec 20, 2022
Comment on lines
99
to
103
| def logging_patterns_to_strip(self): | ||
| return [] | ||
|
|
||
| def stderr_patterns_to_strip(self): | ||
| return [] |
There was a problem hiding this comment.
It feels inconsistent to have stdout here, but not stderr. Should subclasses call through to super class explicitly, so that platform specific patterns could be easily added?
There was a problem hiding this comment.
I think so, I'll remove these empty returns everywhere
JonWBedard
force-pushed
the
eng/run-webkit-tests-Strip-allowsHTTPS-logging-messages
branch
from
ae959cb
to
09fff2a
Compare
|
EWS run on previous version of this PR (hash 09fff2a)
|
JonWBedard
force-pushed
the
eng/run-webkit-tests-Strip-allowsHTTPS-logging-messages
branch
from
09fff2a
to
3b4d097
Compare
|
EWS run on previous version of this PR (hash 3b4d097)
|
|
The extra commit on this PR is to verify that fixing the problem where ref tests don't get their logs filtered fixes this problem. If it does, I'll land this PR and break that extra commit into it's own PR. |
Looks like many of these messages were, in fact, coming from ref tests. That PR is up at #7961, meanwhile, landing this one. |
JonWBedard
force-pushed
the
eng/run-webkit-tests-Strip-allowsHTTPS-logging-messages
branch
from
3b4d097
to
1a41b6e
Compare
JonWBedard
added
the
unsafe-merge-queue
|
EWS run on current version of this PR (hash 1a41b6e)
|
https://bugs.webkit.org/show_bug.cgi?id=249658 rdar://56920527 Reviewed by Alexey Proskuryakov. * Tools/Scripts/webkitpy/port/darwin.py: (DarwinPort.stderr_patterns_to_strip): Strip allows*HTTPS* logging messages. * Tools/Scripts/webkitpy/port/darwin_testcase.py: * Tools/Scripts/webkitpy/port/ios_simulator.py: (IOSSimulatorPort.logging_patterns_to_strip): Deleted. (IOSSimulatorPort.stderr_patterns_to_strip): Deleted. * Tools/Scripts/webkitpy/port/mac.py: (MacPort.stderr_patterns_to_strip): Invoke base class's stderr_patterns_to_strip. * Tools/Scripts/webkitpy/port/watch_simulator.py: (WatchSimulatorPort.logging_patterns_to_strip): Deleted. (WatchSimulatorPort.stderr_patterns_to_strip): Deleted. Canonical link: https://commits.webkit.org/258197@main
webkit-early-warning-system
force-pushed
the
eng/run-webkit-tests-Strip-allowsHTTPS-logging-messages
branch
from
1a41b6e
to
08b7126
Compare
|
Committed 258197@main (08b7126): https://commits.webkit.org/258197@main Reviewed commits have been landed. Closing PR #7917 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
JonWBedard
deleted the
eng/run-webkit-tests-Strip-allowsHTTPS-logging-messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
08b7126
1a41b6e
🧪 style🛠 ios🛠 mac🛠 wpe🛠 🧪 win🧪 bindings🛠 ios-sim🛠 mac-AS-debug🛠 gtk🛠 wincairo🧪 webkitperl🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 tv🧪 mac-wk2🛠 tv-sim🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress🛠 watch-sim