Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSS-Typed-OM] Make sure column-count value gets clamped to [1, inf] #7960

Merged
merged 1 commit into from Dec 21, 2022
Merged

[CSS-Typed-OM] Make sure column-count value gets clamped to [1, inf] #7960

merged 1 commit into from Dec 21, 2022

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Dec 21, 2022 •
edited by webkit-early-warning-system

58acbb9

[CSS-Typed-OM] Make sure `column-count` value gets clamped to [1, inf]
https://bugs.webkit.org/show_bug.cgi?id=249722

Reviewed by Alan Baradlay.

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-count-expected.txt:
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setColumnCount):

Canonical link: https://commits.webkit.org/258218@main

a415beb

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Dec 21, 2022
@cdumez cdumez added the CSS Cascading Style Sheets implementation label Dec 21, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash a415beb)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Dec 21, 2022
@cdumez
[CSS-Typed-OM] Make sure column-count value gets clamped to [1, inf]
58acbb9 
https://bugs.webkit.org/show_bug.cgi?id=249722

Reviewed by Alan Baradlay.

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-count-expected.txt:
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setColumnCount):

Canonical link: https://commits.webkit.org/258218@main
@webkit-commit-queue
Copy link
Collaborator

Committed 258218@main (58acbb9): https://commits.webkit.org/258218@main

Reviewed commits have been landed. Closing PR #7960 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 58acbb9 into WebKit:main Dec 21, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanbaradlay alanbaradlay alanbaradlay approved these changes

@anttijk anttijk Awaiting requested review from anttijk

@smfr smfr Awaiting requested review from smfr

Assignees

@cdumez cdumez

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @alanbaradlay