[JSC] Stop nulling out the CodeBlock spot inside the call frame inside WebAssembly #7991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
|
EWS run on previous version of this PR (hash 8460d97) |
Constellation
force-pushed
the
eng/JSC-Stop-nulling-out-the-CodeBlock-spot-inside-the-call-frame-inside-WebAssembly
branch
from
8460d97
to
da1743a
Compare
|
EWS run on previous version of this PR (hash da1743a) |
Constellation
force-pushed
the
eng/JSC-Stop-nulling-out-the-CodeBlock-spot-inside-the-call-frame-inside-WebAssembly
branch
from
da1743a
to
0a9fc34
Compare
|
EWS run on previous version of this PR (hash 0a9fc34) |
Constellation
force-pushed
the
eng/JSC-Stop-nulling-out-the-CodeBlock-spot-inside-the-call-frame-inside-WebAssembly
branch
2 times, most recently
from
75f373a
to
d2475d6
Compare
|
EWS run on previous version of this PR (hash d2475d6) |
|
EWS run on previous version of this PR (hash 75f373a) |
Constellation
force-pushed
the
eng/JSC-Stop-nulling-out-the-CodeBlock-spot-inside-the-call-frame-inside-WebAssembly
branch
2 times, most recently
from
4744d66
to
d1cceeb
Compare
|
EWS run on previous version of this PR (hash d1cceeb) |
|
EWS run on previous version of this PR (hash 4744d66) |
Constellation
force-pushed
the
eng/JSC-Stop-nulling-out-the-CodeBlock-spot-inside-the-call-frame-inside-WebAssembly
branch
from
d1cceeb
to
8041770
Compare
|
EWS run on current version of this PR (hash 8041770) |
Constellation
added
the
unsafe-merge-queue
…e WebAssembly https://bugs.webkit.org/show_bug.cgi?id=165321 rdar://103618930 Reviewed by Mark Lam. We are putting nullptr unnecessarily to CodeBlock slot while Callee information is enough to say this CallFrame is wasm frame or not. This patch removes it, and fixing places getting CodeBlock from CallFrame with the assumption that it can be nullptr when it is wasm frame. This allows to drop unnecessary zero fill for *all* wasm functions, which is bad. * Source/JavaScriptCore/bytecode/CodeBlock.cpp: (JSC::CodeBlock::noticeIncomingCall): * Source/JavaScriptCore/bytecode/Repatch.cpp: (JSC::linkMonomorphicCall): (JSC::linkDirectCall): (JSC::linkVirtualFor): (JSC::linkPolymorphicCall): * Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::scope): (JSC::DebuggerCallFrame::thisValue const): (JSC::DebuggerCallFrame::evaluateWithScopeExtension): (JSC::DebuggerCallFrame::sourceIDForCallFrame): * Source/JavaScriptCore/dfg/DFGDoesGCCheck.cpp: (JSC::DFG::DoesGCCheck::verifyCanGC): * Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp: (Inspector::functionName): * Source/JavaScriptCore/interpreter/CallFrameInlines.h: (JSC::CallFrame::codeBlock const): * Source/JavaScriptCore/interpreter/Interpreter.cpp: (JSC::Interpreter::unwind): * Source/JavaScriptCore/interpreter/ShadowChicken.cpp: (JSC::ShadowChicken::update): * Source/JavaScriptCore/interpreter/StackVisitor.cpp: (JSC::StackVisitor::readNonInlinedFrame): * Source/JavaScriptCore/jit/JITExceptions.cpp: (JSC::genericUnwind): * Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp: (JSC::PolymorphicCallStubRoutine::PolymorphicCallStubRoutine): * Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp: (JSC::getCallerCodeBlock): * Source/JavaScriptCore/runtime/VM.cpp: (JSC::VM::throwException): * Source/JavaScriptCore/runtime/VMTraps.cpp: (JSC::VMTraps::invalidateCodeBlocksOnStack): * Source/JavaScriptCore/tools/VMInspector.cpp: (JSC::VMInspector::dumpRegisters): * Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h: (JSC::Wasm::ExpressionType>::AirIRGeneratorBase): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::B3IRGenerator): * Source/JavaScriptCore/wasm/js/JSToWasm.cpp: (JSC::Wasm::createJSToWasmWrapper): * Source/JavaScriptCore/wasm/js/WasmToJS.cpp: (JSC::Wasm::wasmToJS): Canonical link: https://commits.webkit.org/258233@main
webkit-early-warning-system
force-pushed
the
eng/JSC-Stop-nulling-out-the-CodeBlock-spot-inside-the-call-frame-inside-WebAssembly
branch
from
8041770
to
5f73a3c
Compare
|
Committed 258233@main (5f73a3c): https://commits.webkit.org/258233@main Reviewed commits have been landed. Closing PR #7991 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Constellation
deleted the
eng/JSC-Stop-nulling-out-the-CodeBlock-spot-inside-the-call-frame-inside-WebAssembly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5f73a3c
8041770
🛠 🧪 win🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 tv🧪 mac-wk2🧪 mac-AS-debug-wk2🛠 watch