Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computed value for stroke-dasharray should be in px #8024

Merged
merged 1 commit into from Dec 23, 2022
Merged

Computed value for stroke-dasharray should be in px #8024

merged 1 commit into from Dec 23, 2022

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Dec 22, 2022 •
edited by webkit-early-warning-system

a618c9c

Computed value for stroke-dasharray should be in px
https://bugs.webkit.org/show_bug.cgi?id=249813

Reviewed by Simon Fraser.

Computed value for stroke-dasharray should be in px:
- https://svgwg.org/svg2-draft/painting.html#StrokeDashing

Previously, we would only convert other length units to px when applied to a
SVG element, not for other kinds of elements.

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-dasharray-expected.txt:
* Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::strokeDashArrayToCSSValueList):

Canonical link: https://commits.webkit.org/258300@main

ab11fbb

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
❌ 🛠 🧪 unsafe-merge

@cdumez cdumez self-assigned this Dec 22, 2022
@cdumez cdumez added the CSS Cascading Style Sheets implementation label Dec 22, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 9785e69)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 gtk-wk2
  🧪 api-ios ❌ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 23, 2022
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Dec 23, 2022
@cdumez cdumez force-pushed the 249813_stroke-dasharray_computed_value_px branch from 9785e69 to ab11fbb Compare December 23, 2022 02:33
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash ab11fbb)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
❌ 🛠 🧪 unsafe-merge

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 23, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the 249813_stroke-dasharray_computed_value_px branch 2 times, most recently from 3c66e2c to 1d21b7b Compare December 23, 2022 17:49
@cdumez
Computed value for stroke-dasharray should be in px
a618c9c 
https://bugs.webkit.org/show_bug.cgi?id=249813

Reviewed by Simon Fraser.

Computed value for stroke-dasharray should be in px:
- https://svgwg.org/svg2-draft/painting.html#StrokeDashing

Previously, we would only convert other length units to px when applied to a
SVG element, not for other kinds of elements.

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-dasharray-expected.txt:
* Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::strokeDashArrayToCSSValueList):

Canonical link: https://commits.webkit.org/258300@main
@webkit-commit-queue
Copy link
Collaborator

Committed 258300@main (a618c9c): https://commits.webkit.org/258300@main

Reviewed commits have been landed. Closing PR #8024 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit a618c9c into WebKit:main Dec 23, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr smfr approved these changes

Assignees

@cdumez cdumez

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
5 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @smfr @webkit-ews-buildbot