Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix css/css-typed-om/the-stylepropertymap/properties/stop-opacity.html WPT test #8026

Merged

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Dec 22, 2022

7f5f721

Fix css/css-typed-om/the-stylepropertymap/properties/stop-opacity.html WPT test
https://bugs.webkit.org/show_bug.cgi?id=249814

Reviewed by Simon Fraser.

Fix css/css-typed-om/the-stylepropertymap/properties/stop-opacity.html WPT test
to match the specification:
- https://svgwg.org/svg2-draft/pservers.html#StopOpacityProperty

This property should allow percentages, not just numbers. Also, the computed
value should be a number in the [0, 1] range, with percentages converted to
numbers.

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stop-opacity-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stop-opacity.html:

Canonical link: https://commits.webkit.org/258272@main

39a304e

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe   πŸ›  πŸ§ͺ win
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac   πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1   πŸ§ͺ api-gtk
βœ… πŸ›  tv   πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim   πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  watch-sim
βœ… πŸ›  πŸ§ͺ unsafe-merge

@cdumez cdumez self-assigned this Dec 22, 2022
@cdumez cdumez added the CSS Cascading Style Sheets implementation label Dec 22, 2022
@cdumez
Copy link
Contributor Author

cdumez commented Dec 22, 2022

Upstream PR: web-platform-tests/wpt#37659

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 23, 2022
…l WPT test

https://bugs.webkit.org/show_bug.cgi?id=249814

Reviewed by Simon Fraser.

Fix css/css-typed-om/the-stylepropertymap/properties/stop-opacity.html WPT test
to match the specification:
- https://svgwg.org/svg2-draft/pservers.html#StopOpacityProperty

This property should allow percentages, not just numbers. Also, the computed
value should be a number in the [0, 1] range, with percentages converted to
numbers.

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stop-opacity-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stop-opacity.html:

Canonical link: https://commits.webkit.org/258272@main
@webkit-commit-queue
Copy link
Collaborator

Committed 258272@main (7f5f721): https://commits.webkit.org/258272@main

Reviewed commits have been landed. Closing PR #8026 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 7f5f721 into WebKit:main Dec 23, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
4 participants