Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows.html WPT test #8038

Merged
merged 1 commit into from Dec 23, 2022
Merged

Fix css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows.html WPT test #8038

merged 1 commit into from Dec 23, 2022

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Dec 23, 2022 •
edited by webkit-early-warning-system

7a882e1

Fix css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows.html WPT test
https://bugs.webkit.org/show_bug.cgi?id=249829

Reviewed by Simon Fraser.

Fix css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows.html
WPT test to match the specification:
- https://w3c.github.io/csswg-drafts/css-grid/#auto-tracks
- https://w3c.github.io/csswg-drafts/css-grid/#typedef-track-size
- https://w3c.github.io/csswg-drafts/css-grid/#typedef-track-breadth

The specification indicates that the track size cannot be a negative value.
However, the tests expects -3.14% as computed value in one of the checks.

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows.html:

Canonical link: https://commits.webkit.org/258296@main

613baed

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@cdumez cdumez self-assigned this Dec 23, 2022
@cdumez cdumez added the CSS Cascading Style Sheets implementation label Dec 23, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 613baed)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@cdumez
Copy link
Contributor Author

cdumez commented Dec 23, 2022

Upstream PR: web-platform-tests/wpt#37667

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 23, 2022
@cdumez
Fix css/css-typed-om/the-stylepropertymap/properties/grid-auto-column…
7a882e1 
…s-rows.html WPT test

https://bugs.webkit.org/show_bug.cgi?id=249829

Reviewed by Simon Fraser.

Fix css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows.html
WPT test to match the specification:
- https://w3c.github.io/csswg-drafts/css-grid/#auto-tracks
- https://w3c.github.io/csswg-drafts/css-grid/#typedef-track-size
- https://w3c.github.io/csswg-drafts/css-grid/#typedef-track-breadth

The specification indicates that the track size cannot be a negative value.
However, the tests expects -3.14% as computed value in one of the checks.

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows.html:

Canonical link: https://commits.webkit.org/258296@main
@webkit-commit-queue
Copy link
Collaborator

Committed 258296@main (7a882e1): https://commits.webkit.org/258296@main

Reviewed commits have been landed. Closing PR #8038 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 7a882e1 into WebKit:main Dec 23, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr smfr approved these changes

@weinig weinig Awaiting requested review from weinig

@nt1m nt1m Awaiting requested review from nt1m

@anttijk anttijk Awaiting requested review from anttijk

@graouts graouts Awaiting requested review from graouts

@heycam heycam Awaiting requested review from heycam

Assignees

@cdumez cdumez

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @smfr