[JSC] Enable Wasm SIMD x64 tests #8041

Constellation · 2022-12-23T08:09:51Z

`5828910`

[JSC] Enable Wasm SIMD x64 tests
https://bugs.webkit.org/show_bug.cgi?id=249836
rdar://103663385

Reviewed by Justin Michaud and Mark Lam.

* JSTests/wasm/stress/simd-kitchen-sink.js:
* JSTests/wasm/v8/exceptions-simd.js:
* JSTests/wasm/v8/regress/regress-10309.js:
* JSTests/wasm/v8/regress/regress-1054466.js:
* JSTests/wasm/v8/regress/regress-1065599.js:
* JSTests/wasm/v8/regress/regress-1070078.js:
* JSTests/wasm/v8/regress/regress-1081030.js:
* JSTests/wasm/v8/regress/regress-10831.js:
* JSTests/wasm/v8/regress/regress-1111522.js:
* JSTests/wasm/v8/regress/regress-1112124.js:
* JSTests/wasm/v8/regress/regress-1116019.js:
* JSTests/wasm/v8/regress/regress-1124885.js:
* JSTests/wasm/v8/regress/regress-1132461.js:
* JSTests/wasm/v8/regress/regress-1161555.js:
* JSTests/wasm/v8/regress/regress-1161654.js:
* JSTests/wasm/v8/regress/regress-1161954.js:
* JSTests/wasm/v8/regress/regress-1165966.js:
* JSTests/wasm/v8/regress/regress-1179182.js:
* JSTests/wasm/v8/regress/regress-1187831.js:
* JSTests/wasm/v8/regress/regress-1188975.js:
* JSTests/wasm/v8/regress/regress-1199662.js:
* JSTests/wasm/v8/regress/regress-1231950.js:
* JSTests/wasm/v8/regress/regress-1242300.js:
* JSTests/wasm/v8/regress/regress-1242689.js:
* JSTests/wasm/v8/regress/regress-1264462.js:
* JSTests/wasm/v8/regress/regress-1271244.js:
* JSTests/wasm/v8/regress/regress-1271456.js:
* JSTests/wasm/v8/regress/regress-1271538.js:
* JSTests/wasm/v8/regress/regress-1282224.js:
* JSTests/wasm/v8/regress/regress-1283042.js:
* JSTests/wasm/v8/regress/regress-1283395.js:
* JSTests/wasm/v8/regress/regress-1284980.js:
* JSTests/wasm/v8/regress/regress-1286253.js:
* JSTests/wasm/v8/regress/regress-1289678.js:
* JSTests/wasm/v8/regress/regress-1290079.js:
* JSTests/wasm/v8/regress/regress-9447.js:
* JSTests/wasm/v8/regress/regress-crbug-1338980.js:
* JSTests/wasm/v8/regress/regress-crbug-1355070.js:
* JSTests/wasm/v8/regress/regress-crbug-1356718.js:

Canonical link: https://commits.webkit.org/258303@main

eba1442

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests
✅ 🛠 🧪 unsafe-merge

webkit-early-warning-system · 2022-12-23T08:10:02Z

EWS run on current version of this PR (hash eba1442)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests
✅ 🛠 🧪 unsafe-merge

MenloDorian

r=me but the commit msg should say “Also skip some tests in preparation for enabling all wasm SIMD tests on x86_64.” I don’t actually see any change to enable the wasm SIMD tests.

MenloDorian · 2022-12-23T17:19:35Z

r=me but the commit msg should say “Also skip some tests in preparation for enabling all wasm SIMD tests on x86_64.” I don’t actually see any change to enable the wasm SIMD tests.

Oops, I misread it: skip if not x86_64, which means allow for x86_64. Ignore me. Carry on.

justinmichaud

r=me too, and I think Mark was confused by the double negative in the skip line

https://bugs.webkit.org/show_bug.cgi?id=249836 rdar://103663385 Reviewed by Justin Michaud and Mark Lam. * JSTests/wasm/stress/simd-kitchen-sink.js: * JSTests/wasm/v8/exceptions-simd.js: * JSTests/wasm/v8/regress/regress-10309.js: * JSTests/wasm/v8/regress/regress-1054466.js: * JSTests/wasm/v8/regress/regress-1065599.js: * JSTests/wasm/v8/regress/regress-1070078.js: * JSTests/wasm/v8/regress/regress-1081030.js: * JSTests/wasm/v8/regress/regress-10831.js: * JSTests/wasm/v8/regress/regress-1111522.js: * JSTests/wasm/v8/regress/regress-1112124.js: * JSTests/wasm/v8/regress/regress-1116019.js: * JSTests/wasm/v8/regress/regress-1124885.js: * JSTests/wasm/v8/regress/regress-1132461.js: * JSTests/wasm/v8/regress/regress-1161555.js: * JSTests/wasm/v8/regress/regress-1161654.js: * JSTests/wasm/v8/regress/regress-1161954.js: * JSTests/wasm/v8/regress/regress-1165966.js: * JSTests/wasm/v8/regress/regress-1179182.js: * JSTests/wasm/v8/regress/regress-1187831.js: * JSTests/wasm/v8/regress/regress-1188975.js: * JSTests/wasm/v8/regress/regress-1199662.js: * JSTests/wasm/v8/regress/regress-1231950.js: * JSTests/wasm/v8/regress/regress-1242300.js: * JSTests/wasm/v8/regress/regress-1242689.js: * JSTests/wasm/v8/regress/regress-1264462.js: * JSTests/wasm/v8/regress/regress-1271244.js: * JSTests/wasm/v8/regress/regress-1271456.js: * JSTests/wasm/v8/regress/regress-1271538.js: * JSTests/wasm/v8/regress/regress-1282224.js: * JSTests/wasm/v8/regress/regress-1283042.js: * JSTests/wasm/v8/regress/regress-1283395.js: * JSTests/wasm/v8/regress/regress-1284980.js: * JSTests/wasm/v8/regress/regress-1286253.js: * JSTests/wasm/v8/regress/regress-1289678.js: * JSTests/wasm/v8/regress/regress-1290079.js: * JSTests/wasm/v8/regress/regress-9447.js: * JSTests/wasm/v8/regress/regress-crbug-1338980.js: * JSTests/wasm/v8/regress/regress-crbug-1355070.js: * JSTests/wasm/v8/regress/regress-crbug-1356718.js: Canonical link: https://commits.webkit.org/258303@main

webkit-commit-queue · 2022-12-23T18:27:54Z

Committed 258303@main (5828910): https://commits.webkit.org/258303@main

Reviewed commits have been landed. Closing PR #8041 and removing active labels.

Constellation requested a review from a team as a code owner December 23, 2022 08:09

Constellation self-assigned this Dec 23, 2022

Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Dec 23, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 23, 2022

Constellation removed the merging-blocked Applied to prevent a change from being merged label Dec 23, 2022

MenloDorian approved these changes Dec 23, 2022

View reviewed changes

justinmichaud approved these changes Dec 23, 2022

View reviewed changes

justinmichaud added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 23, 2022

webkit-early-warning-system force-pushed the eng/JSC-Enable-Wasm-SIMD-x64-tests branch from eba1442 to 5828910 Compare December 23, 2022 18:27

webkit-early-warning-system merged commit 5828910 into WebKit:main Dec 23, 2022

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 23, 2022

Constellation deleted the eng/JSC-Enable-Wasm-SIMD-x64-tests branch December 23, 2022 19:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JSC] Enable Wasm SIMD x64 tests #8041

[JSC] Enable Wasm SIMD x64 tests #8041

Constellation commented Dec 23, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Dec 23, 2022 •

edited

MenloDorian left a comment

MenloDorian commented Dec 23, 2022

justinmichaud left a comment

webkit-commit-queue commented Dec 23, 2022

[JSC] Enable Wasm SIMD x64 tests #8041

[JSC] Enable Wasm SIMD x64 tests #8041

Conversation

Constellation commented Dec 23, 2022 • edited by webkit-early-warning-system

5828910

webkit-early-warning-system commented Dec 23, 2022 • edited

MenloDorian left a comment

Choose a reason for hiding this comment

MenloDorian commented Dec 23, 2022

justinmichaud left a comment

Choose a reason for hiding this comment

webkit-commit-queue commented Dec 23, 2022

Constellation commented Dec 23, 2022 •

edited by webkit-early-warning-system

`5828910`

webkit-early-warning-system commented Dec 23, 2022 •

edited