Remove hspace and vspace attributes from input field #8083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlcow
added
the
Forms
|
EWS run on previous version of this PR (hash 62d8b9a)
|
|
@karlcow - Sweet!! Win Win!!! |
anttijk
approved these changes
Dec 29, 2022
karlcow
force-pushed
the
244279-remove-hspace-vspace
branch
from
62d8b9a
to
fd22a4c
Compare
|
EWS run on current version of this PR (hash fd22a4c)
|
|
@anttijk Next step. merge-queue. 🙏 |
graouts
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=244279 rdar://99356718 Reviewed by Antti Koivisto. Removes hspace and vspace attribute mapping to CSS, but keeps it in the case of input of type=image as mandated by the WPT test in http://wpt.live/html/rendering/unmapped-attributes.html but still passing http://wpt.live/html/rendering/dimension-attributes.html * LayoutTests/imported/w3c/web-platform-tests/html/rendering/unmapped-attributes-expected.txt: * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::collectPresentationalHintsForAttribute): Canonical link: https://commits.webkit.org/258360@main
webkit-commit-queue
force-pushed
the
244279-remove-hspace-vspace
branch
from
fd22a4c
to
9065879
Compare
|
Committed 258360@main (9065879): https://commits.webkit.org/258360@main Reviewed commits have been landed. Closing PR #8083 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
nt1m
reviewed
Dec 31, 2022
Comment on lines
684
to
+688
| } else if (name == hspaceAttr) { | ||
| if (isImageButton()) { | ||
| addHTMLLengthToStyle(style, CSSPropertyMarginLeft, value); | ||
| addHTMLLengthToStyle(style, CSSPropertyMarginRight, value); | ||
| } |
There was a problem hiding this comment.
ooopsie. @nt1m what's the best way to do that usually. Open a new webkit bug with a fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9065879
fd22a4c
🧪 gtk-wk2🧪 api-ios🧪 mac-AS-debug-wk2