[JSC] Make JSToWasmICCallee one of Wasm::Callee #8087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
|
EWS run on previous version of this PR (hash affabde) |
Constellation
force-pushed
the
eng/JSC-Remove-JSToWasmICCallee
branch
from
affabde
to
aa25bef
Compare
|
EWS run on previous version of this PR (hash aa25bef) |
Constellation
changed the title
Constellation
force-pushed
the
eng/JSC-Remove-JSToWasmICCallee
branch
from
aa25bef
to
f9e9dd8
Compare
|
EWS run on previous version of this PR (hash f9e9dd8) |
Constellation
force-pushed
the
eng/JSC-Remove-JSToWasmICCallee
branch
from
f9e9dd8
to
7f66602
Compare
|
EWS run on previous version of this PR (hash 7f66602) |
/replace ... to .../replace ... with .../ |
Constellation
force-pushed
the
eng/JSC-Remove-JSToWasmICCallee
branch
from
7f66602
to
d5520a7
Compare
|
EWS run on current version of this PR (hash d5520a7) |
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=204960 rdar://problem/103740549 Reviewed by Mark Lam. This patch replaces JSCell based JSToWasmICCallee with Wasm::Callee based JSToWasmICCallee, so we do not need to have a bit weird JS cell type for that. * JSTests/stress/sampling-profiler-wasm-name-section.js: (platformSupportsSamplingProfiler.vm.isWasmSupported): * JSTests/stress/sampling-profiler-wasm.js: (platformSupportsSamplingProfiler.vm.isWasmSupported): * JSTests/wasm/function-tests/nameSection.js: * Source/JavaScriptCore/CMakeLists.txt: * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: * Source/JavaScriptCore/Sources.txt: * Source/JavaScriptCore/heap/Heap.h: * Source/JavaScriptCore/heap/HeapSubspaceTypes.h: * Source/JavaScriptCore/interpreter/Interpreter.cpp: (JSC::UnwindFunctor::operator() const): * Source/JavaScriptCore/interpreter/StackVisitor.cpp: (JSC::StackVisitor::Frame::calleeSaveRegistersForUnwinding): * Source/JavaScriptCore/runtime/JSFunction.cpp: (JSC::getCalculatedDisplayName): * Source/JavaScriptCore/runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::visitChildrenImpl): * Source/JavaScriptCore/runtime/JSGlobalObject.h: (JSC::JSGlobalObject::webAssemblyFunctionStructure const): (JSC::JSGlobalObject::jsToWasmICCalleeStructure const): Deleted. * Source/JavaScriptCore/wasm/WasmCallee.cpp: (JSC::Wasm::Callee::runWithDowncast): (JSC::Wasm::JITCallee::JITCallee): (JSC::Wasm::JSToWasmICCallee::previousInstanceOffset): (JSC::Wasm::JSToWasmICCallee::previousInstance): * Source/JavaScriptCore/wasm/WasmCallee.h: (JSC::Wasm::JITCallee::setEntrypoint): * Source/JavaScriptCore/wasm/WasmCompilationMode.cpp: (JSC::Wasm::makeString): * Source/JavaScriptCore/wasm/WasmCompilationMode.h: (JSC::Wasm::isOSREntry): (JSC::Wasm::isAnyBBQ): (JSC::Wasm::isAnyOMG): * Source/JavaScriptCore/wasm/js/JSToWasmICCallee.cpp: Removed. * Source/JavaScriptCore/wasm/js/JSToWasmICCallee.h: Removed. * Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp: (JSC::WebAssemblyFunction::jsCallEntrypointSlow): (JSC::WebAssemblyFunction::visitChildrenImpl): (JSC::WebAssemblyFunction::previousInstanceOffset const): Deleted. (JSC::WebAssemblyFunction::previousInstance): Deleted. * Source/JavaScriptCore/wasm/js/WebAssemblyFunction.h: Canonical link: https://commits.webkit.org/258368@main
webkit-early-warning-system
force-pushed
the
eng/JSC-Remove-JSToWasmICCallee
branch
from
d5520a7
to
08ce70f
Compare
|
Committed 258368@main (08ce70f): https://commits.webkit.org/258368@main Reviewed commits have been landed. Closing PR #8087 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
08ce70f
d5520a7
🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 jsc-armv7-tests🧪 mac-wk2-stress