Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GStreamer][WebRTC] Improved msid support #8133

Merged
merged 1 commit into from Jan 9, 2023

Conversation

philn
Copy link
Member

@philn philn commented Jan 2, 2023

4c9aa3f

[GStreamer][WebRTC] Improved msid support
https://bugs.webkit.org/show_bug.cgi?id=250007

Reviewed by Xabier Rodriguez-Calvar.

GstWebRTCBin can now store the MediaStream ID as a pad property. Fallback to previously used CNAME
otherwise. See also https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3106.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::configureAndLinkSource):
(WebCore::GStreamerMediaEndpoint::requestPad):
(WebCore::GStreamerMediaEndpoint::addRemoteStream):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h:
* Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.h:
(WebCore::RealtimeOutgoingMediaSourceGStreamer::mediaStreamID const):

Canonical link: https://commits.webkit.org/258658@main

1d3eaa8

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@philn philn self-assigned this Jan 2, 2023
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Jan 2, 2023
@philn philn requested a review from calvaris January 2, 2023 18:13
@philn philn added the WebRTC For bugs in WebRTC label Jan 9, 2023
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Jan 9, 2023
https://bugs.webkit.org/show_bug.cgi?id=250007

Reviewed by Xabier Rodriguez-Calvar.

GstWebRTCBin can now store the MediaStream ID as a pad property. Fallback to previously used CNAME
otherwise. See also https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3106.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::configureAndLinkSource):
(WebCore::GStreamerMediaEndpoint::requestPad):
(WebCore::GStreamerMediaEndpoint::addRemoteStream):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h:
* Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.h:
(WebCore::RealtimeOutgoingMediaSourceGStreamer::mediaStreamID const):

Canonical link: https://commits.webkit.org/258658@main
@webkit-commit-queue
Copy link
Collaborator

Committed 258658@main (4c9aa3f): https://commits.webkit.org/258658@main

Reviewed commits have been landed. Closing PR #8133 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4c9aa3f into WebKit:main Jan 9, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 9, 2023
@philn philn deleted the eng/250007 branch January 9, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs. WebRTC For bugs in WebRTC
Projects
None yet
4 participants