Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASSERT(status == U_ZERO_ERROR) under SearchBuffer::search() when typing in the url bar in the iOS simulator #814

Merged
merged 0 commits into from May 20, 2022
Merged

ASSERT(status == U_ZERO_ERROR) under SearchBuffer::search() when typing in the url bar in the iOS simulator #814

merged 0 commits into from May 20, 2022

Conversation

smfr
Copy link
Contributor

@smfr smfr commented May 20, 2022 •
edited by webkit-early-warning-system

a4adc3e

ASSERT(status == U_ZERO_ERROR) under SearchBuffer::search() when typing in the url bar in the iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=240699
<rdar://92182174 >

Reviewed by Tim Horton.

Replace `status == U_ZERO_ERROR` tests with `U_SUCCESS(status)`.

* Source/WebCore/PAL/pal/text/TextCodecICU.cpp:
(PAL::ErrorCallbackSetter::ErrorCallbackSetter):
(PAL::ErrorCallbackSetter::~ErrorCallbackSetter):
* Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm:
(WebKit::SpoofChecker::checker):
* Source/WebCore/editing/TextIterator.cpp:
(WebCore::createSearcher):
(WebCore::SearchBuffer::SearchBuffer):
(WebCore::SearchBuffer::~SearchBuffer):
(WebCore::SearchBuffer::search):

Canonical link: https://commits.webkit.org/250786@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@smfr smfr self-assigned this May 20, 2022
@smfr smfr added Safari Technology Preview Text For bugs in text layout and rendering, including international text support. labels May 20, 2022
@smfr smfr requested a review from litherum May 20, 2022 02:40
@smfr smfr added the merge-queue Applied to send a pull request to merge-queue label May 20, 2022
@webkit-early-warning-system
Copy link
Collaborator

Commit message contains (OOPS!), blocking PR #814

@webkit-early-warning-system webkit-early-warning-system added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels May 20, 2022
@smfr smfr removed merging-blocked Applied to prevent a change from being merged Text For bugs in text layout and rendering, including international text support. Safari Technology Preview labels May 20, 2022
@smfr smfr force-pushed the eng/ASSERTstatus--U_ZERO_ERROR-under-SearchBuffersearch-when-typing-in-the-url-bar-in-the-iOS-simulator branch from 5dd145e to 1a10d34 Compare May 20, 2022 04:09
@smfr smfr added Safari Technology Preview Text For bugs in text layout and rendering, including international text support. merge-queue Applied to send a pull request to merge-queue labels May 20, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/ASSERTstatus--U_ZERO_ERROR-under-SearchBuffersearch-when-typing-in-the-url-bar-in-the-iOS-simulator branch from 1a10d34 to a4adc3e Compare May 20, 2022 05:50
@webkit-early-warning-system webkit-early-warning-system merged commit a4adc3e into WebKit:main May 20, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294531 (250786@main): https://commits.webkit.org/250786@main

Reviewed commits have been landed. Closing PR #814 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 20, 2022
@smfr smfr deleted the eng/ASSERTstatus--U_ZERO_ERROR-under-SearchBuffersearch-when-typing-in-the-url-bar-in-the-iOS-simulator branch May 20, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@litherum litherum Awaiting requested review from litherum

Assignees

@smfr smfr

Labels
Text For bugs in text layout and rendering, including international text support.
Projects
None yet
Milestone
No milestone
3 participants
@smfr @webkit-early-warning-system @hortont424