Web Inspector: Show parent style rules for nested style rules in Styles sidebar #8202

patrickangle · 2023-01-04T19:07:36Z

`b5cf192`

Web Inspector: Show parent style rules for nested style rules in Styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=250088
rdar://100522930

Reviewed by Antti Koivisto.

Add basic support for viewing and editing parent style rule selectors for nested style rules. This uses the same
mechanism we already use for showing parent `@rule`s, including support for editing.

* LayoutTests/inspector/css/getMatchesStylesForNodeNestingStyleGrouping-expected.txt: Added.
* LayoutTests/inspector/css/getMatchesStylesForNodeNestingStyleGrouping.html: Added.

* LayoutTests/inspector/css/setGroupingHeaderText-expected.txt:
* LayoutTests/inspector/css/setGroupingHeaderText.html:
- Add test cases for modifying a parent Style rule's selector via a Grouping on a child nested rule.

* Source/JavaScriptCore/inspector/protocol/CSS.json:
- Add new "StyleRule" grouping type to represent parent style rules.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:

* Source/WebCore/css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::CSSStyleRule):
(WebCore::CSSStyleRule::length const):
(WebCore::CSSStyleRule::item const):
(WebCore::CSSStyleRule::cssRules const):
* Source/WebCore/css/CSSStyleRule.h:
- Add support for getting the nested rules inside a CSSStyleRule.

* Source/WebCore/css/StyleRule.cpp:
(WebCore::StyleRuleBase::createCSSOMWrapper const):
* Source/WebCore/css/StyleRule.h:
- Support creating a wrapper with a CSSStyleRule as a parent.

* Source/WebCore/css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseSelector):
* Source/WebCore/css/parser/CSSParser.h:
- Allow callers to enable nesting syntax for parsing a selector, which is done to verify a selector is valid by Web
Inspector when editing a nested rule's selector.

* Source/WebCore/inspector/InspectorStyleSheet.cpp:
(WebCore::flatteningStrategyForStyleRuleType):
- Style rules can now contain rules, so get rid of the `Commit` strategy and use the existing `CommitSelfThenChildren`
for style rules instead.

(WebCore::isValidRuleHeaderText):
- Pass through the nesting mode for parsing selectors.

(WebCore::protocolGroupingTypeForStyleRuleType):
(WebCore::flattenSourceData):
- Get rid of `Commit` strategy.

(WebCore::StyleSheetHandler::startRuleHeader):
- It is no longer invalid to encounter the start of a style rule before encountering the end of the previous style rule.

(WebCore::asCSSRuleList):

(WebCore::InspectorStyleSheet::buildArrayForGroupings):
- Start with the parent of the passed CSSRule, otherwise every style rule will include itself as a grouping.

(WebCore::isNestedContext):
(WebCore::InspectorStyleSheet::setRuleHeaderText):
- Nested rules should allow relevant syntax for selectors.

(WebCore::InspectorStyleSheet::collectFlatRules):

* Source/WebCore/style/InspectorCSSOMWrappers.cpp:
(WebCore::Style::InspectorCSSOMWrappers::collect):
- Eagerly create CSSOM wrappers for nested rules.

* Source/WebInspectorUI/UserInterface/Models/CSSGrouping.js:
(WI.CSSGrouping.prototype.get isStyle):
(WI.CSSGrouping.prototype.get prefix):
(WI.CSSGrouping):
- Nested rules don't have a prefix like `@rule`s do, so provide a null prefix.

* Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._renderGroupings):
- Support groupings without a prefix by not prepending the prefix.

Canonical link: https://commits.webkit.org/258555@main

e34f118

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
✅ 🛠 🧪 merge	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-01-04T19:07:47Z

EWS run on previous version of this PR (hash e8a25f4)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	❌ 🛠 mac-AS-debug	⏳ 🛠 gtk	~~🛠 wincairo~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	~~🧪 mac-wk2~~	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-01-04T20:17:49Z

EWS run on previous version of this PR (hash e002df3)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk2~~	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-01-04T21:55:10Z

EWS run on previous version of this PR (hash aa8dcdb)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	~~🧪 mac-wk2~~	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-01-04T23:14:04Z

EWS run on previous version of this PR (hash fa13973)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	⏳ 🧪 mac-wk1	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2	~~🧪 jsc-armv7-tests~~
	⏳ 🛠 watch	~~🧪 mac-wk2-stress~~	✅ 🛠 jsc-mips
	⏳ 🛠 watch-sim		~~🧪 jsc-mips-tests~~

webkit-early-warning-system · 2023-01-04T23:17:29Z

EWS run on previous version of this PR (hash 7f323f7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 gtk-wk2
	⏳ 🧪 api-ios	❌ 🧪 mac-wk1	~~🧪 api-gtk~~
❌ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-01-05T05:39:03Z

EWS run on previous version of this PR (hash d2f7cb5)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

Source/WebCore/inspector/InspectorStyleSheet.cpp

Source/WebCore/css/CSSStyleRule.cpp

Source/WebCore/css/CSSStyleRule.h

Source/WebCore/inspector/InspectorStyleSheet.cpp

rcaliman-apple

The front-end parts build elegantly on top of your prior work. Good job 👍

Still pondering how better to display the parent rules to communicate what they are, but this work stands on its own.

Found a couple of other issues with groupings, but I'll open separate bugs:

tab navigation forwards from a previous rule skips the next one's groupings; backwards navigation works fine.
Update: logged Bug 250134
it would be nice to include the grouping prefix when filtering in the Styles panel
Filtering for the string media won't match @media (width: 1200px), but filtering for anything in the condition text will.
Update: logged Bug 250136

Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js

webkit-early-warning-system · 2023-01-05T20:25:17Z

EWS run on previous version of this PR (hash 97671b7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-01-05T21:39:38Z

EWS run on previous version of this PR (hash 5685ee3)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-01-06T00:53:45Z

EWS run on previous version of this PR (hash 9441639)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	⏳ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 mac-wk1	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	❌ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	❌ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	❌ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-01-06T02:17:23Z

EWS run on previous version of this PR (hash 5812776)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
❌ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-01-06T16:19:11Z

EWS run on current version of this PR (hash e34f118)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
✅ 🛠 🧪 merge	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

…es sidebar https://bugs.webkit.org/show_bug.cgi?id=250088 rdar://100522930 Reviewed by Antti Koivisto. Add basic support for viewing and editing parent style rule selectors for nested style rules. This uses the same mechanism we already use for showing parent `@rule`s, including support for editing. * LayoutTests/inspector/css/getMatchesStylesForNodeNestingStyleGrouping-expected.txt: Added. * LayoutTests/inspector/css/getMatchesStylesForNodeNestingStyleGrouping.html: Added. * LayoutTests/inspector/css/setGroupingHeaderText-expected.txt: * LayoutTests/inspector/css/setGroupingHeaderText.html: - Add test cases for modifying a parent Style rule's selector via a Grouping on a child nested rule. * Source/JavaScriptCore/inspector/protocol/CSS.json: - Add new "StyleRule" grouping type to represent parent style rules. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::CSSStyleRule): (WebCore::CSSStyleRule::length const): (WebCore::CSSStyleRule::item const): (WebCore::CSSStyleRule::cssRules const): * Source/WebCore/css/CSSStyleRule.h: - Add support for getting the nested rules inside a CSSStyleRule. * Source/WebCore/css/StyleRule.cpp: (WebCore::StyleRuleBase::createCSSOMWrapper const): * Source/WebCore/css/StyleRule.h: - Support creating a wrapper with a CSSStyleRule as a parent. * Source/WebCore/css/parser/CSSParser.cpp: (WebCore::CSSParser::parseSelector): * Source/WebCore/css/parser/CSSParser.h: - Allow callers to enable nesting syntax for parsing a selector, which is done to verify a selector is valid by Web Inspector when editing a nested rule's selector. * Source/WebCore/inspector/InspectorStyleSheet.cpp: (WebCore::flatteningStrategyForStyleRuleType): - Style rules can now contain rules, so get rid of the `Commit` strategy and use the existing `CommitSelfThenChildren` for style rules instead. (WebCore::isValidRuleHeaderText): - Pass through the nesting mode for parsing selectors. (WebCore::protocolGroupingTypeForStyleRuleType): (WebCore::flattenSourceData): - Get rid of `Commit` strategy. (WebCore::StyleSheetHandler::startRuleHeader): - It is no longer invalid to encounter the start of a style rule before encountering the end of the previous style rule. (WebCore::asCSSRuleList): (WebCore::InspectorStyleSheet::buildArrayForGroupings): - Start with the parent of the passed CSSRule, otherwise every style rule will include itself as a grouping. (WebCore::isNestedContext): (WebCore::InspectorStyleSheet::setRuleHeaderText): - Nested rules should allow relevant syntax for selectors. (WebCore::InspectorStyleSheet::collectFlatRules): * Source/WebCore/style/InspectorCSSOMWrappers.cpp: (WebCore::Style::InspectorCSSOMWrappers::collect): - Eagerly create CSSOM wrappers for nested rules. * Source/WebInspectorUI/UserInterface/Models/CSSGrouping.js: (WI.CSSGrouping.prototype.get isStyle): (WI.CSSGrouping.prototype.get prefix): (WI.CSSGrouping): - Nested rules don't have a prefix like `@rule`s do, so provide a null prefix. * Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js: (WI.SpreadsheetCSSStyleDeclarationSection.prototype._renderGroupings): - Support groupings without a prefix by not prepending the prefix. Canonical link: https://commits.webkit.org/258555@main

webkit-commit-queue · 2023-01-06T20:30:31Z

Committed 258555@main (b5cf192): https://commits.webkit.org/258555@main

Reviewed commits have been landed. Closing PR #8202 and removing active labels.

patrickangle requested a review from dcrousso as a code owner January 4, 2023 19:07

patrickangle self-assigned this Jan 4, 2023

patrickangle added the Web Inspector Bugs related to the WebKit Web Inspector. label Jan 4, 2023

patrickangle requested review from mdubet, anttijk and rcaliman-apple January 4, 2023 19:08

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 4, 2023

patrickangle removed the merging-blocked Applied to prevent a change from being merged label Jan 4, 2023

patrickangle force-pushed the eng/b250088-inspector-css-nesting-support branch from e8a25f4 to e002df3 Compare January 4, 2023 20:17

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 4, 2023

patrickangle removed the merging-blocked Applied to prevent a change from being merged label Jan 4, 2023

patrickangle force-pushed the eng/b250088-inspector-css-nesting-support branch from e002df3 to aa8dcdb Compare January 4, 2023 21:54

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 4, 2023

patrickangle removed the merging-blocked Applied to prevent a change from being merged label Jan 4, 2023

patrickangle force-pushed the eng/b250088-inspector-css-nesting-support branch from aa8dcdb to fa13973 Compare January 4, 2023 23:13

patrickangle force-pushed the eng/b250088-inspector-css-nesting-support branch from fa13973 to 7f323f7 Compare January 4, 2023 23:14

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 5, 2023

patrickangle removed the merging-blocked Applied to prevent a change from being merged label Jan 5, 2023

patrickangle force-pushed the eng/b250088-inspector-css-nesting-support branch from 7f323f7 to d2f7cb5 Compare January 5, 2023 05:36

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 5, 2023

anttijk approved these changes Jan 5, 2023

View reviewed changes

mdubet reviewed Jan 5, 2023

View reviewed changes

Source/WebCore/inspector/InspectorStyleSheet.cpp Show resolved Hide resolved

Source/WebCore/css/CSSStyleRule.cpp Show resolved Hide resolved

Source/WebCore/css/CSSStyleRule.h Show resolved Hide resolved

Source/WebCore/inspector/InspectorStyleSheet.cpp Outdated Show resolved Hide resolved

rcaliman-apple approved these changes Jan 5, 2023

View reviewed changes

Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js Show resolved Hide resolved

patrickangle removed the merging-blocked Applied to prevent a change from being merged label Jan 5, 2023

patrickangle force-pushed the eng/b250088-inspector-css-nesting-support branch from d2f7cb5 to 97671b7 Compare January 5, 2023 20:24

patrickangle force-pushed the eng/b250088-inspector-css-nesting-support branch from 97671b7 to 5685ee3 Compare January 5, 2023 21:35

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 6, 2023

patrickangle removed the merging-blocked Applied to prevent a change from being merged label Jan 6, 2023

patrickangle force-pushed the eng/b250088-inspector-css-nesting-support branch from 5685ee3 to 9441639 Compare January 6, 2023 00:53

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 6, 2023

patrickangle removed the merging-blocked Applied to prevent a change from being merged label Jan 6, 2023

patrickangle force-pushed the eng/b250088-inspector-css-nesting-support branch from 9441639 to 5812776 Compare January 6, 2023 02:17

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 6, 2023

patrickangle removed the merging-blocked Applied to prevent a change from being merged label Jan 6, 2023

patrickangle force-pushed the eng/b250088-inspector-css-nesting-support branch from 5812776 to e34f118 Compare January 6, 2023 16:18

patrickangle added the merge-queue Applied to send a pull request to merge-queue label Jan 6, 2023

webkit-early-warning-system force-pushed the eng/b250088-inspector-css-nesting-support branch from e34f118 to b5cf192 Compare January 6, 2023 20:30

webkit-early-warning-system merged commit b5cf192 into WebKit:main Jan 6, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Web Inspector: Show parent style rules for nested style rules in Styles sidebar #8202

Web Inspector: Show parent style rules for nested style rules in Styles sidebar #8202

patrickangle commented Jan 4, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Jan 4, 2023 •

edited

webkit-early-warning-system commented Jan 4, 2023 •

edited

webkit-early-warning-system commented Jan 4, 2023 •

edited

webkit-early-warning-system commented Jan 4, 2023 •

edited

webkit-early-warning-system commented Jan 4, 2023 •

edited

webkit-early-warning-system commented Jan 5, 2023 •

edited

rcaliman-apple left a comment •

edited

webkit-early-warning-system commented Jan 5, 2023 •

edited

webkit-early-warning-system commented Jan 5, 2023 •

edited

webkit-early-warning-system commented Jan 6, 2023 •

edited

webkit-early-warning-system commented Jan 6, 2023 •

edited

webkit-early-warning-system commented Jan 6, 2023 •

edited

webkit-commit-queue commented Jan 6, 2023

Web Inspector: Show parent style rules for nested style rules in Styles sidebar #8202

Web Inspector: Show parent style rules for nested style rules in Styles sidebar #8202

Conversation

patrickangle commented Jan 4, 2023 • edited by webkit-early-warning-system

b5cf192

webkit-early-warning-system commented Jan 4, 2023 • edited

webkit-early-warning-system commented Jan 4, 2023 • edited

webkit-early-warning-system commented Jan 4, 2023 • edited

webkit-early-warning-system commented Jan 4, 2023 • edited

webkit-early-warning-system commented Jan 4, 2023 • edited

webkit-early-warning-system commented Jan 5, 2023 • edited

rcaliman-apple left a comment • edited

Choose a reason for hiding this comment

webkit-early-warning-system commented Jan 5, 2023 • edited

webkit-early-warning-system commented Jan 5, 2023 • edited

webkit-early-warning-system commented Jan 6, 2023 • edited

webkit-early-warning-system commented Jan 6, 2023 • edited

webkit-early-warning-system commented Jan 6, 2023 • edited

webkit-commit-queue commented Jan 6, 2023

patrickangle commented Jan 4, 2023 •

edited by webkit-early-warning-system

`b5cf192`

webkit-early-warning-system commented Jan 4, 2023 •

edited

webkit-early-warning-system commented Jan 4, 2023 •

edited

webkit-early-warning-system commented Jan 4, 2023 •

edited

webkit-early-warning-system commented Jan 4, 2023 •

edited

webkit-early-warning-system commented Jan 4, 2023 •

edited

webkit-early-warning-system commented Jan 5, 2023 •

edited

rcaliman-apple left a comment •

edited

webkit-early-warning-system commented Jan 5, 2023 •

edited

webkit-early-warning-system commented Jan 5, 2023 •

edited

webkit-early-warning-system commented Jan 6, 2023 •

edited

webkit-early-warning-system commented Jan 6, 2023 •

edited

webkit-early-warning-system commented Jan 6, 2023 •

edited