Clean up from enabling lh/rlh units #8264
Conversation
|
EWS run on previous version of this PR (hash d4b0f7f)
|
Tools/DumpRenderTree/TestOptions.cpp
Outdated
| @@ -150,7 +150,7 @@ const TestFeatures& TestOptions::defaults() | |||
| { "JavaScriptEnabled", true }, | |||
| { "KeygenElementEnabled", false }, | |||
| { "LayoutFormattingContextIntegrationEnabled", true }, | |||
| { "LineHeightUnitsEnabled", false }, | |||
| { "LineHeightUnitsEnabled", true }, | |||
There was a problem hiding this comment.
I think this can be removed if UnifiedWebPreferences.yaml sets the status to stable (which was the intent of the other commit)
There was a problem hiding this comment.
Okay, I'll update the patch to do that.
I'll also modify any layout tests which flip the flag individually.
| @@ -365,9 +365,7 @@ class DeprecatedGlobalSettings { | |||
|
|
|||
| bool m_CSSLogicalEnabled { false }; | |||
|
|
|||
| // False by default until https://bugs.webkit.org/show_bug.cgi?id=211351 / | |||
| // https://github.com/w3c/csswg-drafts/issues/3257 have been sorted out. | |||
| bool m_lineHeightUnitsEnabled { false }; | |||
There was a problem hiding this comment.
Should we remove the corresponding lineHeightUnitsEnabled() & setLineHeightUnitsEnabled and stop exposing it from DeprecatedGlobalSettings (remove the webcoreBinding field) and remove any corresponding usages as well?
There was a problem hiding this comment.
I think removing a flag is a different patch than flipping a flag.
There was a problem hiding this comment.
I was talking about removing it from DeprecatedGlobalSettings (and keeping it on Settings), but glazing at the code, it's not trivial, so punting this seems fine.
litherum
force-pushed
the
eng/Clean-up-from-enabling-lhrlh-units
branch
from
d4b0f7f
to
accc257
Compare
|
EWS run on current version of this PR (hash accc257)
|
https://bugs.webkit.org/show_bug.cgi?id=250163 rdar://103933593 Reviewed by Tim Nguyen. I looked through all the places where the preference name was mentioned. * LayoutTests/imported/w3c/web-platform-tests/css/css-values/lh-rlh-on-root-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-values/lh-unit-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-values/lh-unit-002.html: * Source/WebCore/css/typedom/CSSUnitValue.cpp: (WebCore::CSSUnitValue::parseUnit): * Source/WebCore/page/DeprecatedGlobalSettings.h: * Tools/DumpRenderTree/TestOptions.cpp: (WTR::TestOptions::defaults): Canonical link: https://commits.webkit.org/258603@main
webkit-early-warning-system
force-pushed
the
eng/Clean-up-from-enabling-lhrlh-units
branch
from
accc257
to
c7a1baf
Compare
|
Committed 258603@main (c7a1baf): https://commits.webkit.org/258603@main Reviewed commits have been landed. Closing PR #8264 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
c7a1baf
accc257
🛠 🧪 win🛠 gtk🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 api-gtk🛠 tv🧪 mac-AS-debug-wk2🛠 watch-sim