Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebGPU] Support tier1 level argument buffers #8275

Commits on Jan 9, 2023

  1. [WebGPU] Support tier1 level argument buffers

    https://bugs.webkit.org/show_bug.cgi?id=250123
    <radar://103905011>
    
    Reviewed by Myles C. Maxfield.
    
    Support Tier1 argument buffers which are limited to
    pre-A13 devices and some Intel Macs.
    
    Tested on a pre-A13 iPad Pro.
    
    * Source/WebGPU/WebGPU/BindGroup.mm:
    (WebGPU::sizeOfEntries):
    (WebGPU::Device::createBindGroup):
    Support tier1 ABs.
    
    * Source/WebGPU/WebGPU/BindGroupLayout.h:
    (WebGPU::BindGroupLayout::create):
    Simplify create function.
    
    * Source/WebGPU/WebGPU/BindGroupLayout.mm:
    (WebGPU::createArgumentDescriptor):
    (WebGPU::addDescriptor):
    (WebGPU::Device::createBindGroupLayout):
    (WebGPU::BindGroupLayout::BindGroupLayout):
    (WebGPU::BindGroupLayout::encodedLength const):
    Support tier1 ABs.
    
    * Source/WebGPU/WebGPU/RenderPipeline.mm:
    (WebGPU::createEntryFromStructMember):
    (WebGPU::RenderPipeline::getBindGroupLayout):
    Call Device::createBindLayout instead and pass some additional
    information to be compatible with Tier1 ABs.
    
    Canonical link: https://commits.webkit.org/258651@main
    mwyrzykowski committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    8e36095 View commit details
    Browse the repository at this point in the history